-
Notifications
You must be signed in to change notification settings - Fork 0
MCC-1365296 rewrite as java wrapper #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Libraries need not and should not build AOT or build an uberjar.
This way we can add more values in the future without a breaking change.
This works around an issue in our CI build where it cannot check out the submodule. Personally, I think vendoring is a better practice than using submodules anyway - way simpler, way harder to mess up.
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
330827 | Triggered | RSA Private Key | a3a7314 | mauth-protocol-test-suite/signing-params/rsa-key | View secret |
329054 | Triggered | RSA Private Key | 6d6b8c9 | src/com/mdsol/mauth/clojure/client.clj | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Revoke and rotate the secret.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
c6eb0ff
to
3fb4f91
Compare
Once again, false positive GitGuardian checks. Those are both testing keys. |
@colinphill-mdsol |
See #33. This new PR has a different branch name to auto-link to the appropriate Jira ticket.
Differences from that PR: