Skip to content

MCC-1365296 rewrite as java wrapper #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

colinphill-mdsol
Copy link

See #33. This new PR has a different branch name to auto-link to the appropriate Jira ticket.

Differences from that PR:

  • The test suite is vendored instead of included as a submodule. This sidesteps a problem in the CI build where it failed to check out the submodule. It's also just a lot easier to work with.
  • The old implementation has not been deleted. It is still included so that we can do a gradual switchover.
  • The version is tagged as an alpha. This means we don't need to commit to the API as it stands now, and can make breaking changes if needed. Gives us time to try it out. It also means we don't need to have all the documentation polished and ready for external users yet.

Copy link

gitguardian bot commented May 16, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
330827 Triggered RSA Private Key a3a7314 mauth-protocol-test-suite/signing-params/rsa-key View secret
329054 Triggered RSA Private Key 6d6b8c9 src/com/mdsol/mauth/clojure/client.clj View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Revoke and rotate the secret.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@colinphill-mdsol colinphill-mdsol force-pushed the MCC-1365296-rewrite-as-java-wrapper branch from c6eb0ff to 3fb4f91 Compare May 16, 2025 14:32
@colinphill-mdsol
Copy link
Author

Once again, false positive GitGuardian checks. Those are both testing keys.

@mmajumdar-mdsol
Copy link

@colinphill-mdsol
In request.clj, currently the make-request function is encoding the response body as string by this line
(update response :body json/write-str).
So UI is receiving a double encoded string , as BE is already sending an encoded string, and mauth-client is also updating the response body to string.
So can we remove that code in this PR, this will take care of passing the BE response to UI verbatim.

@colinphill-mdsol colinphill-mdsol marked this pull request as draft May 21, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants