Stream Deck Plus support + some fixes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hehe. Very similar to the changes in my fork. The color issue is that there is now an alpha channel in the color. So a fourth number (which can also be seen in the sample on the site: https://docs.elgato.com/sdk/plugins/registration-procedure#info-parameter). My hack so far is just to accept the extra two bytes but ignoring them. The documentation does not seem very clear if it will always be there or not. |
|
@mdonoughe can you take a look? |
mdonoughe
reviewed
Jan 14, 2024
K900
force-pushed
the
main
branch
2 times, most recently
from
83c5ade to
9883d0d
Compare
K900
changed the title
|
Added proper RGBA colors support, also added docs for the new SD+ stuff. |
K900
changed the title
|
I finally got around to fixing the very obvious issues in my plugin that uses this, so https://gitlab.com/K900/streamdeck-now-playing is now up if anyone is interested in a code sample. |
mdonoughe
approved these changes
Jan 27, 2024
|
Re-ran rustfmt, no other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new message types for all the new Stream Deck+ stuff, fix color parsing for the latest versions of the app, update docs links