Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make rules with proper format #13

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Update make rules with proper format #13

merged 1 commit into from
Mar 16, 2022

Conversation

eirikurj
Copy link
Contributor

Purpose

This PR updates the make rules to

  • support the newer pattern rules format.
  • suppress the warning: ignoring prerequisites on suffix rule definition which newer versions of make (4.3) generate

Expected time until merged

No rush, but should be quick to test and merge.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Make sure code compiles using the updated make rules.

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner March 16, 2022 21:21
@eirikurj eirikurj requested review from anilyil and sseraj March 16, 2022 21:21
@codecov
Copy link

codecov bot commented Mar 16, 2022

The author of this PR, eirikurj, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at support@codecov.io with any questions.

Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have make 4.2.1 locally so I can't check the second point, but the compilation still works

@sseraj sseraj merged commit 07bb6ec into main Mar 16, 2022
@sseraj sseraj deleted the updateMakeRules branch March 16, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants