Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added coverage #88

Merged
merged 6 commits into from
Jul 14, 2021
Merged

Added coverage #88

merged 6 commits into from
Jul 14, 2021

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Jul 9, 2021

Purpose

Added codecov coverage, and also enforced that all tests on the private image should pass.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

@ewu63 ewu63 requested a review from a team as a code owner July 9, 2021 19:46
@codecov
Copy link

codecov bot commented Jul 9, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@00fa117). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #88   +/-   ##
=========================================
  Coverage          ?   49.71%           
=========================================
  Files             ?       10           
  Lines             ?     9679           
  Branches          ?        0           
=========================================
  Hits              ?     4812           
  Misses            ?     4867           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00fa117...30a6985. Read the comment docs.

@ewu63 ewu63 mentioned this pull request Jul 10, 2021
Closed
marcomangano
marcomangano reviewed Jul 12, 2021
View reviewed changes
.github/build_real.sh
@@ -1,3 +1,3 @@
#!/bin/bash
set -e
pip install .[testing]
pip install -e .[testing]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess my question for this PR comes from here: why is this necessary / best practice?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been redirected to the instructions, and I see how this makes sense... but at the same time it looks like it is not necessary for the IDWarp PR, I am getting a bit lost

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, perhaps this is not needed..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope it is needed, and actually idwarp has some missing coverage. I have no idea how it was collecting coverage on some of the tests though..

@ewu63 ewu63 merged commit 0fae0b2 into master Jul 14, 2021
@ewu63 ewu63 deleted the add-coverage branch July 14, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcomangano marcomangano marcomangano approved these changes

@anilyil anilyil Awaiting requested review from anilyil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewu63 @marcomangano