Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name #245

Merged
merged 1 commit into from
May 7, 2024
Merged

Update name #245

merged 1 commit into from
May 7, 2024

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented May 7, 2024

Purpose

Update author name

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner May 7, 2024 05:25
@ewu63 ewu63 requested review from marcomangano and sseraj May 7, 2024 05:25
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.46%. Comparing base (44a25b3) to head (5c9837e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   65.46%   65.46%           
=======================================
  Files          47       47           
  Lines       12266    12266           
=======================================
  Hits         8030     8030           
  Misses       4236     4236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sseraj sseraj merged commit dcf5ff6 into main May 7, 2024
11 checks passed
@sseraj sseraj deleted the update-author branch May 7, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants