-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spanwise Local DV offset #243
Conversation
I don't think the failing docs are my fault
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=======================================
Coverage 65.46% 65.46%
=======================================
Files 47 47
Lines 12265 12266 +1
=======================================
+ Hits 8029 8030 +1
Misses 4236 4236 ☔ View full report in Codecov by Sentry. |
@joanibal docs build failed due to recent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
The title says it all.
It's a small fix for cases where you have spanwiseLocalDV and other variables.
Right now,
self.nDVSW_count
defaults to 0 causing it to overwrite other columns of the Jacobian.Expected time until merged
1 week
Type of change
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable