Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVGeoESP compatibility with ESP 122 #213

Merged
merged 1 commit into from
Jul 20, 2023
Merged

DVGeoESP compatibility with ESP 122 #213

merged 1 commit into from
Jul 20, 2023

Conversation

hajdik
Copy link
Contributor

@hajdik hajdik commented Jul 20, 2023

Purpose

The docker images are being updated from ESP 120 to 122, which is required by TACS for the TACS-CAPS interface. Some of the ESP tests failed due to a minor UI change in ESP's python wrapper. The GCC images on that PR will keep failing until this is merged.

Expected time until merged

Depends on which PR we want to merge first

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

I have a local docker image with new ESP and this branch and the pyGeo tests pass. I'm not sure if this will pass with the old ESP

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@hajdik hajdik requested a review from a team as a code owner July 20, 2023 17:47
@hajdik hajdik requested review from sseraj and ArshSaja July 20, 2023 17:47
@sseraj sseraj changed the title DVGeoESP compatability with ESP 122 DVGeoESP compatibility with ESP 122 Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #213 (470147f) into main (dc41b1f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   64.76%   64.76%           
=======================================
  Files          47       47           
  Lines       12018    12018           
=======================================
  Hits         7784     7784           
  Misses       4234     4234           
Impacted Files Coverage Δ
pygeo/parameterization/DVGeoESP.py 66.57% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@A-CGray A-CGray changed the title DVGeoESP compatibility with ESP 122 DVGeoESP compatibality with ESP 122 Jul 20, 2023
@sseraj sseraj merged commit e829c42 into main Jul 20, 2023
@sseraj sseraj deleted the esp-version-update branch July 20, 2023 18:17
@hajdik hajdik changed the title DVGeoESP compatibality with ESP 122 DVGeoESP compatibility with ESP 122 Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants