Pass the DVname of VSP design variable to vspDV class

[ArshSaja]

Purpose

The DVname in vspDV class was set to None. Thus, when dv.name is called, it returns None. This PR fixes this issue.

Expected time until merged

Type of change

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (non-backwards-compatible fix or feature)
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Documentation update
• Maintenance update
• Other (please describe)

Testing

Checklist

• I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
• I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
• I have run unit and regression tests which pass locally with my changes
• I have added new tests that prove my fix is effective or that my feature works
• I have added necessary documentation

[codecov]

Codecov Report

Merging #156 (fe9ed38) into main (c5cda6d) will decrease coverage by 10.81%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #156       +/-   ##
===========================================
- Coverage   63.90%   53.08%   -10.82%     
===========================================
  Files          47       47               
  Lines       11757    11757               
===========================================
- Hits         7513     6241     -1272     
- Misses       4244     5516     +1272     

Impacted Files	Coverage Δ
pygeo/parameterization/DVGeoVSP.py	81.43% <100.00%> (ø)
pygeo/parameterization/designVars.py	77.65% <100.00%> (ø)
pygeo/parameterization/DVGeoMulti.py	0.39% <0.00%> (-89.38%)	⬇️
pygeo/constraints/areaConstraint.py	50.50% <0.00%> (-25.42%)	⬇️
pygeo/constraints/DVCon.py	68.04% <0.00%> (-3.69%)	⬇️
pygeo/pyBlock.py	45.37% <0.00%> (-1.65%)	⬇️
pygeo/parameterization/DVGeo.py	64.23% <0.00%> (-1.44%)	⬇️
pygeo/topology.py	54.92% <0.00%> (-0.23%)	⬇️
pygeo/__init__.py	91.30% <0.00%> (+8.69%)	⬆️
pygeo/parameterization/__init__.py	88.88% <0.00%> (+11.11%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[joanibal]

Can you provide more context here. Was the code broken before? What is wrong with using dv.name?

[ArshSaja]

For openvsp, since we don't pass the DV name in vspDV class, we set the name of DV as None. Since all of our VSP related work is done mphys, we haven't noticed that issue in MACH. The key is the DV name for both vsp and esp. So, it won't affect anything.

[hajdik]

For openvsp, since we don't pass the DV name in vspDV class, we set the name of DV as None.

Is there a reason we couldn't add names to VSP DVs to keep a more consistent API across the different DVGeo types and DV types? The name is already present in as the key in self.DVs, right?

[ArshSaja]

I changed it to the default case. Now the DV name is passed to the vspDV class.

[eirikurj]

@ArshSaja can you update the PR name and purpose to be consistent with the content

[ArshSaja]

I updated the PR details. @eirikurj