Skip to content

Updated formatting #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

Updated formatting #74

merged 1 commit into from
Mar 30, 2022

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Mar 30, 2022

Purpose

Formatting update to match the new version of black so the nightly tests pass

Expected time until merged

Today

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner March 30, 2022 16:08
@sseraj sseraj requested review from yqliaohk and anilyil March 30, 2022 16:08
anilyil
anilyil approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@anilyil anilyil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this will work?

eirikurj
eirikurj approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@eirikurj eirikurj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha @sseraj I was seconds from submitting the same PR

@sseraj sseraj merged commit 108d143 into main Mar 30, 2022
@sseraj sseraj deleted the update-format branch March 30, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirikurj eirikurj eirikurj approved these changes

@anilyil anilyil anilyil approved these changes

@yqliaohk yqliaohk Awaiting requested review from yqliaohk yqliaohk is a code owner automatically assigned from mdolab/mach_aero_maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sseraj @eirikurj @anilyil