Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(newsletter): add public sign-up page #8686

Merged
merged 4 commits into from
May 22, 2023
Merged

feat(newsletter): add public sign-up page #8686

merged 4 commits into from
May 22, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 20, 2023 •
edited by LeoMcA
Loading

Summary

This adds a new page allowing users to subscribe to MDN's newsletter.

(MP-348)

Screenshots

Screen Shot 2023-05-16 at 16 26 32

Screen Shot 2023-05-16 at 16 26 42

How did you test this change?

add to your rumba settings:

[basket]
api_key = "foobar"
basket_url = "https://basket.mozilla.org"

visit /en-US/newsletter

fiji-flo and others added 2 commits April 20, 2023 15:04
@fiji-flo
feature(newsletter): add a public mdn newsletter
87fe046 
This adds a new page allowing users to subscribe to
MDN's newsletter.
@caugner
style: remove unused import
2adeeed
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Apr 21, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@caugner caugner marked this pull request as draft May 2, 2023 12:07
@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label May 16, 2023
@LeoMcA LeoMcA requested a review from fiji-flo May 16, 2023 15:32
@LeoMcA LeoMcA marked this pull request as ready for review May 16, 2023 15:32
@LeoMcA LeoMcA temporarily deployed to stage May 16, 2023 16:08 — with GitHub Actions Inactive
fiji-flo
fiji-flo approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@fiji-flo fiji-flo merged commit bf3fbf7 into main May 22, 2023
@fiji-flo fiji-flo deleted the mdn-newsletter branch May 22, 2023 11:50
@github-actions github-actions bot mentioned this pull request May 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiji-flo fiji-flo fiji-flo approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caugner @fiji-flo @LeoMcA