Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): remove dependecies on client #6765

Merged
merged 3 commits into from
Aug 12, 2022

Conversation

fiji-flo
Copy link
Contributor

No description provided.

@fiji-flo fiji-flo requested a review from LeoMcA July 25, 2022 10:13
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, otherwise looks good!

@@ -11,5 +11,5 @@
"noFallthroughCasesInSwitch": true,
"jsx": "react-jsx"
},
"include": ["src"]
"include": ["src", "../libs/types/types.ts"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary, since types has its own tsconfig?

@fiji-flo fiji-flo force-pushed the remove-dependencies-to-client branch from f9601e0 to 0cc7fe2 Compare August 12, 2022 11:53
@github-actions github-actions bot added the plus work around features related to MDN Plus label Aug 12, 2022
@fiji-flo fiji-flo merged commit cfae0e0 into main Aug 12, 2022
@fiji-flo fiji-flo deleted the remove-dependencies-to-client branch August 12, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plus work around features related to MDN Plus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants