-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tsconfig): move compilerOptions up #6489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That test failure surprises me, but it looks like |
caugner
force-pushed
the
tsconfig-consolidation
branch
from
June 7, 2022 16:51
405012f
to
395b457
Compare
caugner
force-pushed
the
tsconfig-consolidation
branch
from
June 7, 2022 16:56
395b457
to
b6892d1
Compare
caugner
changed the title
chore(tsconfig): consolidate configs
chore(tsconfig): move compilerOptions up
Jun 7, 2022
LeoMcA
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also remove resolveJsonModule
from tsconfig.dist.json
?
otherwise, looks good!
caugner
force-pushed
the
tsconfig-consolidation
branch
from
June 9, 2022 14:06
b6892d1
to
a9d29cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates our
tsconfig.json
somewhat by moving some commoncompilerOptions
into our roottsconfig.json
:allowSyntheticDefaultImports = true
esModuleInterop = true
forceConsistentCasingInFileNames = true
moduleResolution = node
resolveJsonModule = true
skipLibCheck = true
Exceptions:
/markdown/tsconfig.json
needsesModuleInterop = false
./client/pwa/tsconfig.json
doesn't extend/tsconfig.json
.Note: Partially extracted from #6487.
How did you test this change?