Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bcd): improve titles for support behind flags #5616

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Mar 14, 2022

Summary

Fixes #5429.

Problem

When hovering about a feature that is only supported behind a flag,

  • the title of the cross icon would say "Full support", and
  • the title of the flag icon would say "disabled".

Solution

  1. The title on the cross icon now says "No support" to be consistent with the icon.
  2. The title on the flag icon now says "User must explicitly enable this feature." like the legend.

Screenshots

Before

Screenshot 2022-03-14 at 22 15 57

image

After

Screenshot 2022-03-14 at 22 16 57

Screenshot 2022-03-14 at 22 17 06


How did you test this change?

  1. I opened http://localhost:3000/en-US/docs/Web/HTML/Element/menu#browser_compatibility locally.
  2. I hovered over the icons for the feature row <hr> creates a separator and the Firefox for Android column.

@caugner caugner added the browser-compat issues related to the browser compatibility data tables (BCD) label Mar 14, 2022
@caugner caugner requested a review from fiji-flo March 14, 2022 21:27
@caugner caugner added the redesign issues related to the new design label Mar 14, 2022
@caugner caugner requested review from schalkneethling and removed request for fiji-flo March 16, 2022 17:10
@schalkneethling schalkneethling self-assigned this Mar 16, 2022
@schalkneethling schalkneethling merged commit 3e3623e into mdn:main Mar 16, 2022
@caugner caugner deleted the bcd-fix-support-with-flags branch March 16, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-compat issues related to the browser compatibility data tables (BCD) redesign issues related to the new design
Projects
Development

Successfully merging this pull request may close these issues.

BCD table shows "Full support" title for support with flags
2 participants