Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nested dl's with p #4221

Merged
merged 1 commit into from
Jul 20, 2021
Merged

fix nested dl's with p #4221

merged 1 commit into from
Jul 20, 2021

Conversation

fiji-flo
Copy link
Contributor

thing
nested definition:
thang
stuff

I'm what breaks it

was broken

@fiji-flo
fix nested dl's with p
2b7176e 
<dl>
  <dt>thing</dt>
  <dd>nested definition:
    <dl>
      <dt>thang</dt>
      <dd>stuff</dd>
    </dl>
    <p>I'm what breaks it</p>
  </dd>
</dl>

was broken
@fiji-flo fiji-flo mentioned this pull request Jul 15, 2021
Closed
@fiji-flo
Copy link
Contributor Author

resolves #4205

@fiji-flo
Copy link
Contributor Author

We could spend more work to not insert additional paragraphs but that's tedious work. This is a rough explanation of spread remarkjs/remark#364

@wbamberg I don't think it's worth it, how about you?

@wbamberg
Copy link
Collaborator

To be clear, is the PR in mdn/content#6936 generated using this patched version?

If so it looks fine to me.

@fiji-flo
Copy link
Contributor Author

Yes mdn/content#6936 was generated with this PR

@fiji-flo fiji-flo requested a review from peterbe July 19, 2021 08:18
@peterbe
Copy link
Contributor

peterbe commented Jul 19, 2021

How should I review this? Because of the way we split up the work, I never worked on the Markdown AST stuff so I have not frame of reference to understand it.
Wouldn't it be better if @wbamberg reviews this. He stands a much better chance at understanding if the code change solves the problem.
I could review it but it'd be quite an investment to first understand what it does and how it works.

@fiji-flo
Copy link
Contributor Author

I cannot add @wbamberg as a reviewer but he gave his okay. Happy to just merge it.

@fiji-flo fiji-flo merged commit c8c5860 into mdn:main Jul 20, 2021
@fiji-flo fiji-flo deleted the fix-dl-for-real branch July 20, 2021 14:28
@caugner caugner mentioned this pull request Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbe peterbe Awaiting requested review from peterbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fiji-flo @wbamberg @peterbe