Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add EditorConfig for whitespace #2700

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Conversation

nschonni
Copy link
Collaborator

Copied from original version in mdn/content and added Python config

Copied from original version in mdn/content and added Python config
@peterbe
Copy link
Contributor

peterbe commented Jan 26, 2021

How do I test this? Like, is there a command line thing I can run that compares the config with a file?

Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I'm still not 100% comfortable with EditorConfig. I'm so confused as to what's going with VSCode and Black and Prettier and the magic is mixes.

Any objections @fiji-flo ?

@nschonni
Copy link
Collaborator Author

How do I test this? Like, is there a command line thing I can run that compares the config with a file?

No, it's really aimed at telling your IDE what it should use. There is an old depricated tool someone else wrote called "eclint". Might do a separate PR with some cleanups with it later, but it's 'dumb' and doesn't do any proper AST. Tools like Prettier also read this config

@Ryuno-Ki
Copy link

How do I test this?

Ideally, your IDE should insert the right indentation (or even fix it?) depending on what's defined.
As mentioned before, there's a VS Code extension that teaches VS Code how to read an .editorconfig.

@peterbe peterbe requested a review from fiji-flo January 26, 2021 22:51
@peterbe
Copy link
Contributor

peterbe commented Jan 28, 2021

@fiji-flo ping r?

Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 guess I'll delete my local .editorconfig now

@fiji-flo fiji-flo merged commit ad93760 into mdn:master Jan 29, 2021
@nschonni nschonni deleted the editorconfig branch January 29, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants