Skip to content

Conversation

@apasov
Copy link

@apasov apasov commented Oct 24, 2020

fixes #1521

Avoid repetition

Co-authored-by: Peter Bengtsson <peterbe@mozilla.com>
@peterbe
Copy link
Contributor

peterbe commented Oct 27, 2020

@escattone @chrisdavidmills I'm not sure who should review this one but I would recommend whatever we decide here, we'll mirror it in https://github.com/mdn/kumascript/pull/1435/files

Base automatically changed from master to main February 16, 2021 16:38
@peterbe
Copy link
Contributor

peterbe commented Jul 7, 2021

@apasov Sorry that this has gone so stale. Would you mind merging in the latest main and see if you can fix the merge conflict?

@apasov
Copy link
Author

apasov commented Jul 19, 2021

@peterbe I resolved the conflict.

@peterbe
Copy link
Contributor

peterbe commented Jul 19, 2021

@apasov Now it says there are 0 differences :)
Screen Shot 2021-07-19 at 4 49 00 PM

@apasov
Copy link
Author

apasov commented Jul 20, 2021

@peterbe Looks like you have already merged these changes here and here from my mirror PR on mdn/kumascript which is archived now. That's why no differencies :)

@peterbe
Copy link
Contributor

peterbe commented Jul 21, 2021

So close now?

@apasov apasov closed this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants