Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flaws): shared assets images must no be flaws #12133

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix(flaws): shared assets images must no be flaws #12133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(flaws): shared assets images must no be flaws
  • Loading branch information
@fiji-flo
fiji-flo committed Nov 15, 2024
commit ffd07ce08baa69225f392d0fa102d5bcad3bc23c
5 changes: 4 additions & 1 deletion build/check-images.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,10 @@ export function checkImageReferences(
// might be something like `screenshot.png` for the sake of rendering
// it now, we still want the full relative URL.
img.attr("src", absoluteURL.pathname);
} else {
} else if (
absoluteURL.hostname !== "mdn.github.io" ||
!absoluteURL.pathname.startsWith("/shared-assets/")
) {
addImageFlaw(img, src, {
explanation: "External image URL",
externalImage: true,
Expand Down
Loading