fix(build): fix iframe title + div ids #11344
Conversation
- Don't mututate the DOM in collectClosestCode. We'll use the same title as with regual live samples. - Strip suffix from iframe height height="400px" => height="400". - Don't add ids to divs?! Currnet we add ids to notes by accident: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_grid_layout/Masonry_layout#sect1
There was a problem hiding this comment.
LGTM, but the warning message could be clearer.
Also: It would be nice for our translators to run a full build once, gather all the warnings, and put them as a checklist in an issue in translated-content, so that they have a chance to look at the affected live samples.
fiji-flo
changed the title
| @@ -16,7 +16,7 @@ <h2 id="Flexbox">Flexbox</h2> | |||
| and also tests that prerequisites are handled as part of the rendering | |||
| and live-sample-building process. | |||
| --> | |||
| <div id="Flex_1">{{ Page("Learn/CSS/CSS_layout/Introduction/Flex/Stuff", "Flex_1") }}</div> | |||
| <section id="Flex_1">{{ Page("Learn/CSS/CSS_layout/Introduction/Flex/Stuff", "Flex_1") }}</section> | |||
There was a problem hiding this comment.
@fiji-flo Do you know whether there are any occurrences of <div id="..."> outside of code blocks in content or translated-content that might have been added intentionally and are used to link to them?
Does rari check that the targets of anchor links are actually defined? I believe yari does not, but this would probably be useful, as links to anchors that don't exist are essentially dead links.
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
merge conflicts 🚧
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Summary
How did you test this change?
Locally