menu-demo to Manifest v3 #634
+116
−116
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,120 +1,121 @@ | ||
| /* | ||
| Called when a menu item is created, or when creation fails due to an error. | ||
| We log the error here. | ||
| */ | ||
| function onCreated() { | ||
| if (browser.runtime.lastError) { | ||
|
Member
There was a problem hiding this comment.
I think that it would still be useful to log an error to show how error handling works. The The
Collaborator
Author
There was a problem hiding this comment. @Rob--W done, plus some tweaks to the comments |
||
| console.log(`Error: ${browser.runtime.lastError.message}`); | ||
| } | ||
| } | ||
|
|
||
| /* | ||
| Called when the menu item is removed. | ||
| We log success here. | ||
| */ | ||
| function onRemoved() { | ||
| console.log("Item removed successfully"); | ||
| } | ||
|
|
||
| /* | ||
| Called when there is an error in removing a menu item. | ||
| We log the error here. | ||
| */ | ||
| function onError(error) { | ||
| console.log(`Error: ${error}`); | ||
| } | ||
|
|
||
| /* | ||
| Creates all the context menu items. | ||
| */ | ||
| browser.runtime.onInstalled.addListener(() => { | ||
| browser.menus.create({ | ||
| id: "log-selection", | ||
| title: browser.i18n.getMessage("menuItemSelectionLogger"), | ||
| contexts: ["selection"] | ||
| }, onCreated); | ||
|
|
||
| browser.menus.create({ | ||
| id: "remove-me", | ||
| title: browser.i18n.getMessage("menuItemRemoveMe"), | ||
| contexts: ["all"] | ||
| }, onCreated); | ||
|
|
||
| browser.menus.create({ | ||
| id: "separator-1", | ||
| type: "separator", | ||
| contexts: ["all"] | ||
| }, onCreated); | ||
|
|
||
| browser.menus.create({ | ||
| id: "greenify", | ||
| type: "radio", | ||
| title: browser.i18n.getMessage("menuItemGreenify"), | ||
| contexts: ["all"], | ||
| checked: true, | ||
| icons: { | ||
| "16": "icons/paint-green-16.png", | ||
| "32": "icons/paint-green-32.png" | ||
| } | ||
| }, onCreated); | ||
|
|
||
| browser.menus.create({ | ||
| id: "bluify", | ||
| type: "radio", | ||
| title: browser.i18n.getMessage("menuItemBluify"), | ||
| contexts: ["all"], | ||
| checked: false, | ||
| icons: { | ||
| "16": "icons/paint-blue-16.png", | ||
| "32": "icons/paint-blue-32.png" | ||
| } | ||
| }, onCreated); | ||
|
|
||
| browser.menus.create({ | ||
| id: "separator-2", | ||
| type: "separator", | ||
| contexts: ["all"] | ||
| }, onCreated); | ||
|
|
||
| browser.menus.create({ | ||
| id: "check-uncheck", | ||
| type: "checkbox", | ||
| title: browser.i18n.getMessage("menuItemUncheckMe"), | ||
| contexts: ["all"], | ||
| checked: true, | ||
| }, onCreated); | ||
|
|
||
| browser.menus.create({ | ||
| id: "open-sidebar", | ||
| title: browser.i18n.getMessage("menuItemOpenSidebar"), | ||
| contexts: ["all"], | ||
| command: "_execute_sidebar_action" | ||
| }, onCreated); | ||
|
|
||
| browser.menus.create({ | ||
| id: "tools-menu", | ||
| title: browser.i18n.getMessage("menuItemToolsMenu"), | ||
| contexts: ["tools_menu"], | ||
| }, onCreated); | ||
| }); | ||
|
|
||
| /* | ||
| Sets a colored border on the document in the tab returned by the onClicked listener. | ||
|
|
||
| Note that this only works on normal web pages, not special pages, such as about:debugging. | ||
| */ | ||
| const blue = "5px solid blue"; | ||
| const green = "5px solid green"; | ||
|
|
||
| function borderify(tabId, color) { | ||
| browser.scripting.executeScript({ | ||
| target: { tabId }, | ||
| func: (border) => { document.body.style.border = border; }, | ||
| args: [color] | ||
| }); | ||
| } | ||
|
|
||
| /* | ||
| Updates the menu item's title according to "checked" value. | ||
| */ | ||
| function updateCheckUncheck(checkedState) { | ||
| if (checkedState) { | ||
|
|
@@ -129,17 +130,15 @@ function updateCheckUncheck(checkedState) { | |
| } | ||
|
|
||
| /* | ||
| The click event listener, where the extension performs the appropriate action given the ID of the menu item clicked. | ||
| */ | ||
| browser.menus.onClicked.addListener((info, tab) => { | ||
| switch (info.menuItemId) { | ||
| case "log-selection": | ||
| console.log(info.selectionText); | ||
| break; | ||
| case "remove-me": | ||
| browser.menus.remove(info.menuItemId).then(onRemoved, onError); | ||
| break; | ||
| case "bluify": | ||
| borderify(tab.id, blue); | ||
|
|
@@ -151,7 +150,7 @@ browser.menus.onClicked.addListener((info, tab) => { | |
| updateCheckUncheck(info.checked); | ||
| break; | ||
| case "open-sidebar": | ||
| console.warn("_execute_sidebar_action not supported"); | ||
| break; | ||
| case "tools-menu": | ||
| console.log("Clicked the tools menu item"); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep
runtime.lastErroras an example, see my comment in background.js.