Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]: sync the translation of the "How to use promises" guide #19573

Merged
merged 7 commits into from
Apr 22, 2024
Merged

[zh-cn]: sync the translation of the "How to use promises" guide #19573

merged 7 commits into from
Apr 22, 2024

Conversation

JasonLamv-t
Copy link
Member

@JasonLamv-t JasonLamv-t commented Apr 17, 2024 •
edited by yin1999
Loading

Description

As the title.

Motivation

Ditto.

Additional details

None.

Related issues and pull requests

Fixes: #18827

@JasonLamv-t JasonLamv-t requested a review from a team as a code owner April 17, 2024 04:54
@JasonLamv-t JasonLamv-t requested review from irvin and removed request for a team April 17, 2024 04:54
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Apr 17, 2024
@JasonLamv-t JasonLamv-t linked an issue Apr 17, 2024 that may be closed by this pull request
指南中关于 Promise 术语的错误 #18827
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited
Loading

Preview URLs

Flaws (16)

URL: /zh-CN/docs/Learn/JavaScript/Asynchronous/Promises
Title: 如何使用 Promise
Flaw count: 16

  • macros:
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started
    • and 10 more flaws omitted
  • broken_links:
    • Can't resolve /zh-CN/docs/Learn/Common_questions/What_are_browser_developer_tools
External URLs (2)

URL: /zh-CN/docs/Learn/JavaScript/Asynchronous/Promises
Title: 如何使用 Promise

(comment last updated: 2024-04-22 04:50:54)

@JasonLamv-t @github-actions
Update files/zh-cn/learn/javascript/asynchronous/promises/index.md
7165c6c 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yin1999 yin1999 changed the title [zh-cn]: fix problem reported in #18827 and sync the translation with upstream [zh-cn]: sync the translation of "How to use promises" guide Apr 18, 2024
@yin1999 yin1999 changed the title [zh-cn]: sync the translation of "How to use promises" guide [zh-cn]: sync the translation of the "How to use promises" guide Apr 18, 2024
yin1999
yin1999 reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits:

files/zh-cn/learn/javascript/asynchronous/promises/index.md Outdated Show resolved Hide resolved
files/zh-cn/learn/javascript/asynchronous/promises/index.md Outdated Show resolved Hide resolved
files/zh-cn/learn/javascript/asynchronous/promises/index.md Outdated Show resolved Hide resolved
files/zh-cn/learn/javascript/asynchronous/promises/index.md Outdated Show resolved Hide resolved
files/zh-cn/learn/javascript/asynchronous/promises/index.md Outdated Show resolved Hide resolved
files/zh-cn/learn/javascript/asynchronous/promises/index.md Outdated Show resolved Hide resolved
files/zh-cn/learn/javascript/asynchronous/promises/index.md Outdated Show resolved Hide resolved
@JasonLamv-t @yin1999
Apply suggestions from code review
763c69b 
Co-authored-by: A1lo <yin199909@aliyun.com>
@JasonLamv-t JasonLamv-t requested a review from yin1999 April 22, 2024 03:43
yin1999
yin1999 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yin1999 yin1999 merged commit a6723b0 into mdn:main Apr 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@yin1999 yin1999 yin1999 approved these changes

@irvin irvin Awaiting requested review from irvin irvin is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

指南中关于 Promise 术语的错误
2 participants
@JasonLamv-t @yin1999