Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-CN] Init FileSystemFileHandle #15505

Merged
merged 9 commits into from
Aug 31, 2023
Merged

[zh-CN] Init FileSystemFileHandle #15505

merged 9 commits into from
Aug 31, 2023

Conversation

BSPR0002
Copy link
Contributor

@BSPR0002 BSPR0002 commented Aug 30, 2023 •
edited
Loading

Motivation

Init FileSystemFileHandle.
Update contents of File System API to sync with contents of the new translated.

@BSPR0002
[zh-CN] Init FileSystemFileHandle
0d56eec 
Init FileSystemFileHandle.
Update contents of File System Access API  to sync with contents of  the new translated.
@BSPR0002
Merge remote-tracking branch 'upstream/main' into 20230716
beb3fbd
@BSPR0002 BSPR0002 requested a review from a team as a code owner August 30, 2023 05:43
@BSPR0002 BSPR0002 requested review from t7yang and removed request for a team August 30, 2023 05:43
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Aug 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023 •
edited
Loading

Preview URLs

Flaws (34)

URL: /zh-CN/docs/Web/API/FileSystemFileHandle
Title: FileSystemFileHandle
Flaw count: 6

  • macros:
    • /zh-CN/docs/Web/API/FileSystemSyncAccessHandle does not exist but fell back to /en-US/docs/Web/API/FileSystemSyncAccessHandle
    • /zh-CN/docs/Web/API/FileSystemWritableFileStream does not exist but fell back to /en-US/docs/Web/API/FileSystemWritableFileStream
    • /zh-CN/docs/Web/API/FileSystemSyncAccessHandle/close does not exist but fell back to /en-US/docs/Web/API/FileSystemSyncAccessHandle/close
    • /zh-CN/docs/Web/API/FileSystemSyncAccessHandle/flush does not exist but fell back to /en-US/docs/Web/API/FileSystemSyncAccessHandle/flush
    • /zh-CN/docs/Web/API/FileSystemSyncAccessHandle/getSize does not exist but fell back to /en-US/docs/Web/API/FileSystemSyncAccessHandle/getSize
    • and 1 more flaws omitted

URL: /zh-CN/docs/Web/API/FileSystemFileHandle/createWritable
Title: FileSystemFileHandle：createWritable() 方法
Flaw count: 3

  • macros:
    • /zh-CN/docs/Web/API/FileSystemWritableFileStream does not exist but fell back to /en-US/docs/Web/API/FileSystemWritableFileStream
    • /zh-CN/docs/Web/API/FileSystemWritableFileStream does not exist but fell back to /en-US/docs/Web/API/FileSystemWritableFileStream
    • /zh-CN/docs/Web/API/PermissionStatus/state does not exist but fell back to /en-US/docs/Web/API/PermissionStatus/state

URL: /zh-CN/docs/Web/API/FileSystemFileHandle/createSyncAccessHandle
Title: FileSystemFileHandle：createSyncAccessHandle() 方法
Flaw count: 8

  • macros:
    • /zh-CN/docs/Web/API/FileSystemSyncAccessHandle does not exist but fell back to /en-US/docs/Web/API/FileSystemSyncAccessHandle
    • /zh-CN/docs/Web/API/FileSystemSyncAccessHandle does not exist but fell back to /en-US/docs/Web/API/FileSystemSyncAccessHandle
    • /zh-CN/docs/Web/API/FileSystemSyncAccessHandle does not exist but fell back to /en-US/docs/Web/API/FileSystemSyncAccessHandle
    • /zh-CN/docs/Web/API/FileSystemWritableFileStream does not exist but fell back to /en-US/docs/Web/API/FileSystemWritableFileStream
    • /zh-CN/docs/Web/API/FileSystemSyncAccessHandle does not exist but fell back to /en-US/docs/Web/API/FileSystemSyncAccessHandle
    • and 1 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /zh-CN/docs/Web/API/FileSystemFileHandle/getFile
Title: FileSystemFileHandle：getFile() 方法
Flaw count: 1

  • macros:
    • /zh-CN/docs/Web/API/PermissionStatus/state does not exist but fell back to /en-US/docs/Web/API/PermissionStatus/state

URL: /zh-CN/docs/Web/API/File_System_API
Title: 文件系统 API
Flaw count: 16

  • macros:
    • /zh-CN/docs/Web/API/FileSystemDirectoryHandle does not exist but fell back to /en-US/docs/Web/API/FileSystemDirectoryHandle
    • /zh-CN/docs/Web/API/DataTransferItem/getAsFileSystemHandle does not exist but fell back to /en-US/docs/Web/API/DataTransferItem/getAsFileSystemHandle
    • /zh-CN/docs/Web/API/FileSystemWritableFileStream does not exist but fell back to /en-US/docs/Web/API/FileSystemWritableFileStream
    • /zh-CN/docs/Web/API/FileSystemSyncAccessHandle does not exist but fell back to /en-US/docs/Web/API/FileSystemSyncAccessHandle
    • /zh-CN/docs/Web/API/FileSystemSyncAccessHandle/write does not exist but fell back to /en-US/docs/Web/API/FileSystemSyncAccessHandle/write
    • and 10 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
External URLs (5)

URL: /zh-CN/docs/Web/API/FileSystemFileHandle
Title: FileSystemFileHandle

URL: /zh-CN/docs/Web/API/FileSystemFileHandle/createWritable
Title: FileSystemFileHandle：createWritable() 方法

URL: /zh-CN/docs/Web/API/FileSystemFileHandle/createSyncAccessHandle
Title: FileSystemFileHandle：createSyncAccessHandle() 方法

URL: /zh-CN/docs/Web/API/FileSystemFileHandle/getFile
Title: FileSystemFileHandle：getFile() 方法

(comment last updated: 2023-08-31 06:31:20)

yin1999
yin1999 reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions. Maybe you should update your local mdn/content repo

files/zh-cn/web/api/file_system_api/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/filesystemfilehandle/createsyncaccesshandle/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/filesystemfilehandle/createwritable/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/filesystemfilehandle/getfile/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/filesystemfilehandle/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/filesystemfilehandle/createwritable/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/filesystemfilehandle/createwritable/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/filesystemfilehandle/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/filesystemfilehandle/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/filesystemfilehandle/index.md Outdated Show resolved Hide resolved
@BSPR0002 @yin1999
Apply suggestions from code review
8438db3 
Co-authored-by: A1lo <yin199909@aliyun.com>
BSPR0002
BSPR0002 commented Aug 31, 2023
View reviewed changes
Copy link
Contributor Author

@BSPR0002 BSPR0002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch was created on July 16th, and after completing some of the content, I put it on hold. After that, the File System API was updated, so there were some omissions in the subsequent modifications.

files/zh-cn/web/api/filesystemfilehandle/createwritable/index.md Outdated Show resolved Hide resolved
yin1999
yin1999 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BSPR0002 🎉

@yin1999 yin1999 merged commit 81ce1ad into mdn:main Aug 31, 2023
7 checks passed
@BSPR0002 BSPR0002 deleted the 20230716 branch August 31, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@yin1999 yin1999 yin1999 approved these changes

@t7yang t7yang Awaiting requested review from t7yang t7yang is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BSPR0002 @yin1999