refactor: rename http*Redirects/RedirectEntry to http*Route/RouteEntry - #560
Draft
caugner wants to merge 1 commit into
Draft
refactor: rename http*Redirects/RedirectEntry to http*Route/RouteEntry#560caugner wants to merge 1 commit into
http*Redirects/RedirectEntry to http*Route/RouteEntry#560caugner wants to merge 1 commit into
Conversation
…uteEntry` Align the internal redirect-chain field and type names with the "route" terminology already used by the redirection analyzer. These fields are retriever-populated and analyzer-consumed within a single scan; they are not persisted to the database nor exposed by the API, so this is a pure internal rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename the internal redirect-chain response fields
httpRedirects/httpsRedirectstohttpRoute/httpsRoute, and the associated typesRedirectEntry/SerializedRedirectEntrytoRouteEntry/SerializedRouteEntry.Motivation
Align the field and type names with the "route" terminology already used by the redirection analyzer (the local
routevariable andRedirectionOutput.route).Additional details
These fields are populated by the retriever and consumed by the analyzer within a single scan; they are not persisted to the database and not exposed by the API, so this is a pure internal rename with no breaking change.
redirectHistory(theSessionaccumulator field) is intentionally left unchanged.Related issues and pull requests