Add HTML example for <a> (issue #1014) #1022
Conversation
| a[href^="http"]::before { | ||
| content: '↑ '; | ||
| font-style: italic; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Nit: Missing empty line at end of file.
| @@ -0,0 +1,4 @@ | |||
| a[href^="http"]::before { | |||
| content: '↑ '; | |||
There was a problem hiding this comment.
I would suggest using the following icon(as SVG) to stay consistent with the rest of MDN:
https://fontawesome.com/icons/external-link-alt?style=solid
|
Good stuff, @schalkneethling. Changes are in. |
There was a problem hiding this comment.
One tiny nit, and then this is good to merge. Thanks @stephanmax - it looks great r+w/c
| margin-right: 3px; | ||
| opacity: .6; | ||
| width: 0.9em; | ||
| height: 0.8em; |
There was a problem hiding this comment.
Nit: Code Style: No leading zero for fraction based values.
https://stylelint.io/user-guide/rules/number-leading-zero/
|
Thanks, @schalkneethling. I updated the CSS. |
|
@stephanmax Yup, that is something I am working on. |
* upstream/master: (33 commits) Add HTML example for <a> (issue mdn#1014) (mdn#1022) fix(tabbed): load fonts as part of the editor css as @font-face does not work inside shadow dom (mdn#1015) html/input: Lowercase attributes (mdn#1024) Add color-adjust property example (mdn#1008) chore(deps): update dependency eslint to v5.1.0 (mdn#1023) chore(community): add @goodwin64 as contributor (mdn#1021) chore(community): add @dagolinuxoid as contributor (mdn#1020) chore(community): add @arai-a as contributor (mdn#1019) chore(community): add @ro-ka as contributor (mdn#1018) Issue mdn#1013 <style> elements in HTML editor break editor's render method (mdn#1017) chore(deps): update jest monorepo to v23.3.0 (mdn#1012) Issue#946 open links in new tab (mdn#1009) Send metric only during loading event (mdn#1011) fix(performance): only send loading mark inside loading event (mdn#1010) chore(deps): update dependency prettier to v1.13.7 (mdn#1006) fix(address): add name to the provided address (mdn#1004) chore(community): add @Arkangus as contributor (mdn#1002) Correct "expected output" mistake (mdn#1000) fix(performance): send post to kuma for custom ie-load-event-end metric (mdn#1001) chore(deps): update jest monorepo to v23.2.0 (mdn#993) ...
2 participants
This example includes external, relative, email, and telephone links.