chore(lint): regenerate package-lock to check validity #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
732d906 was deployed to: https://fred-pr832.review.mdn.allizom.net/ |
caugner
reviewed
Sep 29, 2025
Comment on lines
+41
to
+42
| npm install | ||
| diff package-lock.json package-lock.json.branch |
Contributor
There was a problem hiding this comment.
If I understand this correctly, then this assumes that running npm install results in the same package-lock.json. However, if a PR adds a dependency (with a subtree of transitive dependencies), then one simultaneous release of one of those transitive dependencies (while the PR is open) might cause this workflow to fail.
I also think this might fail if the PR branch is behind main, afaik github.base_ref points to the latest commit on main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds step to lint workflow to regenerate package-lock.json if it differs, to check unintended changes aren't included e.g. when changing deps with a dirty
node_modulesdir.Draft while I test it works on github actions.