Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indexeddb demo #90

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Add indexeddb demo #90

merged 1 commit into from
Jan 17, 2022

Conversation

wbamberg
Copy link
Contributor

@wbamberg wbamberg commented Jan 15, 2022

To fix mdn/content#10941, this PR transfers the demo currently at https://developer.mozilla.org/en-US/docs/Web/API/IndexedDB_API/Using_IndexedDB#full_indexeddb_example, because I don't think long-form demos work very well as huge code blocks in the page.

The code needs some attention, but I thought it would be better to transfer it first, then improve it once it is here.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to move this large chunk of code here but haven't reviewed it itself. As you say, improvements/fixes can come after the initial import.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, approved too fast! There is a commit to the resize observer example which shouldn't be part of this PR

@wbamberg
Copy link
Contributor Author

Oops, thank you for catching that @Elchi3 . Should be fixed now?

@wbamberg
Copy link
Contributor Author

Good idea to move this large chunk of code here but haven't reviewed it itself. As you say, improvements/fixes can come after the initial import.

I have checked it works, but it is very much in need of improvement. But I thought it would be much easier to review by moving it as-is, then applying changes in a separate PR.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, all good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "Using IndexedDB": broken live demo link
2 participants