EditContext: Handle backward selections and remove double underline #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rumyra
approved these changes
Feb 1, 2024
wbamberg
reviewed
Mar 6, 2024
| } | ||
|
|
||
| // Render the initial view. | ||
| render(); | ||
| setInterval(render, 1000); |
There was a problem hiding this comment.
Can you explain why we have to do this now? It has the unfortunate effect of making it impossible to use the devtools inspector for the rendered text.
There was a problem hiding this comment.
I can't remember why I added this. Tested again without it, and I'm not seeing any issue so far. I'll open a PR to remove this. Thanks Will.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EditContext API now supports backward selections, so I needed to update the code. Also, the double underline style for IME text formats is going away, so I removed the code for it.