Skip to content

Conversation

PrajwalBorkar
Copy link
Contributor

@wbamberg Please review the changes

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @PrajwalBorkar !

(I saw you made this PR from your master branch: it's always a good idea to make changes in a separate feature branch. It won't affect this PR but it will make htings easier for you if you want to make more contributions to this repo.)

@wbamberg wbamberg merged commit d8b98d4 into mdn:master Jun 10, 2022
@PrajwalBorkar
Copy link
Contributor Author

👍 thank you @PrajwalBorkar !

(I saw you made this PR from your master branch: it's always a good idea to make changes in a separate feature branch. It won't affect this PR but it will make htings easier for you if you want to make more contributions to this repo.)

I had just one small change suggested by you that's why I pushed from master branch. If you have any more work for me, I will make the contributions using best practices :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants