Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BiquadFilterNode constructor miss the Chrome note #123

Closed
teoli2003 opened this issue Oct 11, 2017 · 1 comment
Closed

BiquadFilterNode constructor miss the Chrome note #123

teoli2003 opened this issue Oct 11, 2017 · 1 comment

Comments

@teoli2003
Copy link
Contributor

teoli2003 commented Oct 11, 2017

Hi!

BiquadFilterNode's constructor (has a note for Chromes and Operas:
"[1] Before Chrome 59, the default values were not supported. "

I missed it during my review, hence this issue, sorry @chrisdavidmills.

@teoli2003
Copy link
Contributor Author

Bad repo. sorry.

teoli2003 pushed a commit that referenced this issue Sep 7, 2023
<!-- 🙌 Thanks for contributing! Adding details below will help us to
merge your PR faster. -->

### Description

#### Summary

This PR adds multiple related features that go together to enable the
creation of exit/entrance animations using simple CSS, or to put it
another way, animating to/from `display: none`, or animating elements
when they have just been added to the DOM.

Specifically, these are:

-
[`@starting-style`](https://chromestatus.com/feature/4515377717968896):
Chrome 117
- [The `overlay`
property](https://chromestatus.com/feature/5138724910792704): Chrome 117
- [Animating to/from `display: none` and `content-visibility:
hidden`](https://chromestatus.com/feature/5154958272364544): Chrome 116
- [The `transition-behavior`
property](https://chromestatus.com/feature/5071230636392448): Chrome 117
(this was already added, but it is related, so I checked it)

See my [research
document](https://docs.google.com/document/d/1esudzJfl1xpALiPDJ5cdISWGT4zvhZOsiixSriqc_sk/edit)
for more details of what this project aims to add.

<!-- ✍️ Summarize your changes in one or two sentences -->

### Motivation

<!-- ❓ Why are you making these changes and how do they help? -->

### Additional details

<!-- 🔗 Link to documentation, bug trackers, source control, or other
places providing more context -->

### Related issues and pull requests

<!-- 🔨 If this fully resolves a GitHub issue, use "Fixes #123" -->
<!-- 👉 Highlight related pull requests using "Relates to #123" -->
<!-- ❗ If another pull request should be merged first, use "**Depends
on:** #123" -->
teoli2003 pushed a commit that referenced this issue Oct 9, 2023
#674)

<!-- 🙌 Thanks for contributing! Adding details below will help us to
merge your PR faster. -->

### Description

The `initial-value` descriptor of `@property` rules is not limited to
strings.
It permits any value.

### Motivation

`<string>` is incorrect.

### Additional details

see :
https://drafts.css-houdini.org/css-properties-values-api/#the-syntax-descriptor

### Related issues and pull requests

N/A

<!-- 🔨 If this fully resolves a GitHub issue, use "Fixes #123" -->
<!-- 👉 Highlight related pull requests using "Relates to #123" -->
<!-- ❗ If another pull request should be merged first, use "**Depends
on:** #123" -->

---------

Co-authored-by: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com>
bsmth pushed a commit that referenced this issue Nov 8, 2023
<!-- 🙌 Thanks for contributing! Adding details below will help us to
merge your PR faster. -->

### Description

The `@scope` at-rule shipped in Chrome 118 (see
https://chromestatus.com/feature/5100672734199808). This PR adds data
for it.

<!-- ✍️ Summarize your changes in one or two sentences -->

### Motivation

<!-- ❓ Why are you making these changes and how do they help? -->

### Additional details

<!-- 🔗 Link to documentation, bug trackers, source control, or other
places providing more context -->

### Related issues and pull requests

<!-- 🔨 If this fully resolves a GitHub issue, use "Fixes #123" -->
<!-- 👉 Highlight related pull requests using "Relates to #123" -->
<!-- ❗ If another pull request should be merged first, use "**Depends
on:** #123" -->
teoli2003 pushed a commit that referenced this issue Dec 28, 2023
…hidden (#690)

<!-- 🙌 Thanks for contributing! Adding details below will help us to
merge your PR faster. -->

### Description

In #688, part of the work was to add
descriptions of the new specific animation behavior of certain
"discrete" animated properties — `display`, `content-visibility`, and
`overlay` — when animating from a hidden state or a visible state.
However, on talking to some Chrome engineering folks about this, I
realized that some of my descriptions were not quite right.

This PR aims to fix those descriptions.

The description I was sent by the Chrome engineering folk is as follows:

"The idea behind "p = 1" is that during transitions between certain
values for certain properties which we consider invisible to visible or
vice versa, the browser will automatically choose the "visible" option
for the duration of the animation it creates.
For example, if you transition from "display:none" to "display:block",
the element will be "display:block" for the entire animation created by
the transition.
And likewise if you transition from "display:block" to "display:none",
the element will be "display:block" for the entire animation created by
the transition.
However, if you transition from "display:flex" to "display:block", the
element's display value will switch halfway through the animation.
This behavior is applied to content-visibility:hidden, display:none,
visibility:hidden, and overlay:none."

<!-- ✍️ Summarize your changes in one or two sentences -->

### Motivation

<!-- ❓ Why are you making these changes and how do they help? -->

### Additional details

<!-- 🔗 Link to documentation, bug trackers, source control, or other
places providing more context -->

### Related issues and pull requests

<!-- 🔨 If this fully resolves a GitHub issue, use "Fixes #123" -->
<!-- 👉 Highlight related pull requests using "Relates to #123" -->
<!-- ❗ If another pull request should be merged first, use "**Depends
on:** #123" -->
teoli2003 pushed a commit that referenced this issue Jan 15, 2024
<!-- 🙌 Thanks for contributing! Adding details below will help us to
merge your PR faster. -->

<!-- Commits need to adhere to conventional commits and only `fix:` and
`feat:` commits are added to the release notes. -->
<!-- https://www.conventionalcommits.org/en/v1.0.0/#examples -->

### Description

Added some Japanese translations.

### Motivation

To display animation-related properties correctly.

### Additional details

<!-- 🔗 Link to documentation, bug trackers, source control, or other
places providing more context -->

### Related issues and pull requests

<!-- 🔨 If this fully resolves a GitHub issue, use "Fixes #123" -->
<!-- 👉 Highlight related pull requests using "Relates to #123" -->
<!-- ❗ If another pull request should be merged first, use "**Depends
on:** #123" -->
teoli2003 pushed a commit that referenced this issue Jan 23, 2024
<!-- 🙌 Thanks for contributing! Adding details below will help us to
merge your PR faster. -->

<!-- Commits need to adhere to conventional commits and only `fix:` and
`feat:` commits are added to the release notes. -->
<!-- https://www.conventionalcommits.org/en/v1.0.0/#examples -->

### Description

Copy the `alsoAppliesTo` data from `background-position` to
`background-position-x` and `background-position-y`, an obvious
derivation from the shorthand property.

### Motivation

Provide more complete/detailed "Formal definition" data for MDN CSS
property reference.

### Additional details

<!-- 🔗 Link to documentation, bug trackers, source control, or other
places providing more context -->

### Related issues and pull requests

<!-- 🔨 If this fully resolves a GitHub issue, use "Fixes #123" -->
<!-- 👉 Highlight related pull requests using "Relates to #123" -->
<!-- ❗ If another pull request should be merged first, use "**Depends
on:** #123" -->
bsmth pushed a commit that referenced this issue Feb 22, 2024
…l value (#714)

…l value

<!-- 🙌 Thanks for contributing! Adding details below will help us to
merge your PR faster. -->

<!-- Commits need to adhere to conventional commits and only `fix:` and
`feat:` commits are added to the release notes. -->
<!-- https://www.conventionalcommits.org/en/v1.0.0/#examples -->

### Description

The page says that the mask-position Initial value is center, but when I
tested it in Chrome, Firefox, etc., it was not center.
So I changed the initial value of the mask-position property from center
to 0% 0%.

### Motivation

It will be helpful for people working with CSS by referring to the mdn
document.

### Additional details

#713
https://developer.mozilla.org/en-US/docs/Web/CSS/mask-position

### Related issues and pull requests

<!-- 🔨 If this fully resolves a GitHub issue, use "Fixes #123" -->
<!-- 👉 Highlight related pull requests using "Relates to #123" -->
<!-- ❗ If another pull request should be merged first, use "**Depends
on:** #123" -->
bsmth pushed a commit that referenced this issue Feb 27, 2024
<!-- 🙌 Thanks for contributing! Adding details below will help us to
merge your PR faster. -->

<!-- Commits need to adhere to conventional commits and only `fix:` and
`feat:` commits are added to the release notes. -->
<!-- https://www.conventionalcommits.org/en/v1.0.0/#examples -->

### Description

The animation type of `font-palette` recently changed from discrete to
by computed value. This PR reflects this change in the data. See
https://drafts.csswg.org/css-fonts/#font-palette-prop

<!-- ✍️ Summarize your changes in one or two sentences -->

### Motivation

<!-- ❓ Why are you making these changes and how do they help? -->

### Additional details

<!-- 🔗 Link to documentation, bug trackers, source control, or other
places providing more context -->

### Related issues and pull requests

<!-- 🔨 If this fully resolves a GitHub issue, use "Fixes #123" -->
<!-- 👉 Highlight related pull requests using "Relates to #123" -->
<!-- ❗ If another pull request should be merged first, use "**Depends
on:** #123" -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant