Skip to content

fix: Typos in file/en-us/game folder #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Dec 22, 2020
Merged

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Dec 21, 2020

Fixed related spelling issues when the same misspelling was found outside the game folder through find/replace

@nschonni nschonni requested review from a team as code owners December 21, 2020 22:10
@nschonni nschonni requested a review from a team December 21, 2020 22:10
@nschonni nschonni requested a review from a team as a code owner December 21, 2020 22:10
@sideshowbarker
Copy link
Member

Might be good to re-title this PR — since there are changes in trees other than just in the file/en-us/game tree (which is fine of course, assuming it’s intentional — that you didn’t intend to restrict this to just the file/en-us/game, despite the title…)

@nschonni
Copy link
Contributor Author

@sideshowbarker yeah, I was running cSpell on the games folder, but did find/replace the fixes outside the folder when I got hits

Copy link
Member

@vkWeb vkWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm a fan of cspell. 💯

LGTM @nschonni.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant fix ;-)

I love the mass copy and paste "milliseconds" error ;-)

@chrisdavidmills chrisdavidmills merged commit e9b1253 into mdn:main Dec 22, 2020
@nschonni nschonni deleted the typos2 branch December 22, 2020 07:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants