Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update warning & add links to more info #5167

Merged
merged 1 commit into from
May 20, 2021
Merged

Update warning & add links to more info #5167

merged 1 commit into from
May 20, 2021

Conversation

caitmuenster
Copy link
Contributor

Fixes #4908.

Updates warning note about using Element.innerHTML in extensions and adds link to https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Safely_inserting_external_content_into_a_page.

@wagnerand, could you review this?

@caitmuenster caitmuenster added the Content:WebExt WebExtensions docs label May 20, 2021
@caitmuenster caitmuenster requested a review from a team as a code owner May 20, 2021 19:38
@caitmuenster caitmuenster requested review from jpmedley, a team and rpl and removed request for a team and jpmedley May 20, 2021 19:38
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/Element/innerHTML
Title: Element.innerHTML
on GitHub
Flaw count: 3

  • macros:
    • /en-us/docs/web/api/parentnode (url: /en-US/docs/Web/API/ParentNode) does not exist
    • /en-us/docs/web/api/animatable (url: /en-US/docs/Web/API/Animatable) does not exist
  • broken_links:
    • Can't resolve https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/Safely_inserting_external_content_into_a_page

External URLs

URL: /en-US/docs/Web/API/Element/innerHTML
Title: Element.innerHTML
on GitHub

@jpmedley jpmedley merged commit aac2766 into main May 20, 2021
@jpmedley jpmedley deleted the update-inner-html-warnings branch May 20, 2021 19:54
wagnerand
wagnerand reviewed May 20, 2021
View reviewed changes
Copy link
Contributor

@wagnerand wagnerand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@wagnerand

This comment has been minimized.

Sign in to view
@wagnerand
Copy link
Contributor

wagnerand commented May 20, 2021 •
edited
Loading

Ah, so what we want is probably a relative link?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnerand wagnerand

@jpmedley jpmedley

@rpl rpl

Assignees
No one assigned
Labels
Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with "Element.innerHTML": in the warning 'don't use for AMO', give a solution
3 participants
@caitmuenster @wagnerand @jpmedley