chore: Push devDepenencies and mark private #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
force-pushed
the
package-clean
branch
2 times, most recently
from
246c6fb to
3c12952
Compare
nschonni
force-pushed
the
package-clean
branch
3 times, most recently
from
e44923a to
6ac6eaf
Compare
|
@peterbe does this make sense to you or should I close it? |
peterbe
suggested changes
Jan 7, 2021
There was a problem hiding this comment.
Right. We'll never ship this to npmjs.com as a npm package. At least no plans to do so. And if we change our minds on that, we'll need to just do the work to split that up if necessary.
But why devDependencies instead of dependencies?
If you can explain/justify that and fix the merge conflict, I'll all game for this.
nschonni
force-pushed
the
package-clean
branch
from
6ac6eaf to
910b7fd
Compare
Because I saw it as more of tools that are used to produce an end output rather than depenencies on an app that is deployed. Could be flipped all to |
peterbe
reviewed
Jan 7, 2021
nschonni
force-pushed
the
package-clean
branch
from
910b7fd to
6c6f776
Compare
peterbe
approved these changes
Jan 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is currently all content, I don't think the difference between devDependencies and dependencies is a big deal. Also marked
privatesince it's not a published package