-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch master to main #4480
Switch master to main #4480
Conversation
Switching over the default branch in the examples to "main" to match current standards. I also wrote a note to explain the switch from "master," which I tried to not make too outspoken while suggesting that main should be the default of choice. By all means feel free to make the note more blunt, and hope this helps :)
I wonder if there is a good link to share in that note as to why this change is suggested? |
I was looking for one, as I also thought it'd help. There really wasn't an announcement made about all this. The only reference I could find was to a tweet by Nat Friedman in June 2020, which is when people knew that it would happen (that is the source on all the news websites around that time). There really is no substance though. There's also the renaming repo for GitHub that makes it clear that the change is suggested, but then does not provide a justification. That repo is the one that's referenced across GitHub channels as where people should go to learn more about the change. A link with a justification that they use in that readme comes from Software Freedom Conservancy and Git, which starts with the following, but doesn't go further:
I think that the above is as strong a comment from an organization related to this change as we're going to find, and it's also referenced on BitBucket and GitLab. The comment could potentially be changed to reference "version control services" and then that link would fit:
|
files/en-us/learn/tools_and_testing/understanding_client-side_tools/deployment/index.html
Outdated
Show resolved
Hide resolved
files/en-us/learn/tools_and_testing/understanding_client-side_tools/deployment/index.html
Outdated
Show resolved
Hide resolved
Preview URLsFlawsURL:
External URLsURL:
(this comment was updated 2021-05-20 12:42:20.103160) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, it's not a controversial "social/civil" issue because the new default is main
on GitHub.
I approve but with nits.
I actually did some research last year for freeCodeCamp/chapter#434 |
@andrewtavis , Peter had some comments on this which were marked resolved, but I don't see the changes in the diff. Did you mean to accept the suggestions? I'm happy to merge this if we can resolve them. |
@wbamberg, my apologies. I had been worried that something else was needed on my end for this. I was a bit confused on how I couldn't directly approve the changes in the review of them, so I just resolved them. I guess I didn't see how to do that properly. With this being said, I accept the changes fully and you can merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @andrewtavis You ignored my suggestions. You marked them as resolved.
You need to either press the "Commit suggestion" (first you might need to "Unresolve conversation") or do it manually in your code editor.
…tools/deployment/index.html Co-authored-by: Peter Bengtsson <peterbe@mozilla.com>
…tools/deployment/index.html Co-authored-by: Peter Bengtsson <peterbe@mozilla.com>
@peterbe, thanks for the directions on that! Didn't realize the difference between resolving and committing the changes. I thought that we were waiting for Chris' review on all this. Appreciate your explanation! |
I don't think I need to review this as well, so removing myself from the list to avoid any more holdups. |
No worries, @andrewtavis . You would not be the first person to be confused by this bit of GitHub's UI :). |
Switching over the default branch in the examples to
main
to match current standards. I also wrote a note to explain the switch frommaster
, which I tried to not make too outspoken while suggesting thatmain
should be the default of choice. By all means feel free to make the note more blunt, and hope this helps :)