AudioNode::disconnect signatures #42985
Open
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add other missing method signatures to AudioNode disconnect() method, according to specification
CodeSmith32
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add other missing method signatures to AudioNode disconnect() method, according to specification
Description
The
AudioNodedisconnectmethod description was missing several signatures indicated by the specification, which this PR adds.Motivation
I came to MDN looking for the full set of signature overloads, but had to skip to the specification instead.
Additional details
Specification signatures: https://webaudio.github.io/web-audio-api/#dom-audionode-disconnect
Related issues and pull requests