-
Notifications
You must be signed in to change notification settings - Fork 23.1k
reorder CSS layout test your skills for consistency #42953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorder CSS layout test your skills for consistency #42953
Conversation
|
Preview URLs (4 pages)
Flaws (4) Found an unexpected or unresolvable flaw? Please report it here. URL:
URL:
URL:
URL:
(comment last updated: 2026-01-30 14:09:48) |
dipikabh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chrisdavidmills.
That's a good strategy to avoid confusion and makes better sense - adding the starting point rendering before the expected output. I have a small suggestion to reorder the frames within the starting blocks: show the rendered iframe first and then the corresponding code snippets.
I've also left a few small edits in nearby text.
Leaving a +1
files/en-us/learn_web_development/core/css_layout/test_your_skills/flexbox/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/css_layout/test_your_skills/flexbox/index.md
Show resolved
Hide resolved
files/en-us/learn_web_development/core/css_layout/test_your_skills/flexbox/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/css_layout/test_your_skills/flexbox/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/css_layout/test_your_skills/flexbox/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/css_layout/test_your_skills/grid/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/css_layout/test_your_skills/position/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/css_layout/test_your_skills/position/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/css_layout/test_your_skills/position/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/css_layout/test_your_skills/position/index.md
Outdated
Show resolved
Hide resolved
…ills/flexbox/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/flexbox/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/flexbox/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/floats/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/grid/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/position/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/position/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/position/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/position/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/grid/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/grid/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/grid/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
files/en-us/learn_web_development/core/css_layout/test_your_skills/grid/index.md
Show resolved
Hide resolved
…ills/grid/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/floats/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/floats/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
…ills/grid/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Description
I got some feedback that the ordering of the "Test your skills" articles has become confusing since the last update. Specifically, in some of the tests, the "solution" live sample appears before the "starting state" live sample, so it is unclear which one to click on to start the test.
To remedy this, I have decided to go through all the "Test your skills" articles and make the structure as consistent as possible throughout, fixing the above issue in the process.
This PR in particular updates the structure of the CSS layout "Test your skills" articles.
Note: Not all of the tests show the finished state of the example. I have elected not to show it in cases where the before and after rendering look no different, where the final rendering gives away the answer, and where the question is freeform so there is no single answer.
Motivation
Additional details
Related issues and pull requests