Fix allowable properties for ::highlight pseudo-element #42866
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:CSS
Contributor
|
Preview URLs (1 page) (comment last updated: 2026-01-26 13:48:51) |
estelle
requested changes
Jan 26, 2026
Member
estelle
left a comment
estelle
left a comment
There was a problem hiding this comment.
made a suggestion.
if the -webkit- aren't in the spec, we don't need to mention them
Comment on lines
23
to
25
| - {{CSSxRef("stroke")}}, {{CSSxRef("fill")}}, and {{CSSxRef("stroke-width")}} | ||
|
|
||
| Vendor-prefixed properties such as {{CSSxRef("-webkit-text-stroke-color")}} or {{CSSxRef("-webkit-text-fill-color")}} do not apply to highlight pseudo-elements. |
Member
There was a problem hiding this comment.
Suggested change
| - {{CSSxRef("stroke")}}, {{CSSxRef("fill")}}, and {{CSSxRef("stroke-width")}} | |
| Vendor-prefixed properties such as {{CSSxRef("-webkit-text-stroke-color")}} or {{CSSxRef("-webkit-text-fill-color")}} do not apply to highlight pseudo-elements. | |
| - {{CSSxRef("stroke-color")}}, {{CSSxRef("fill-color")}}, and {{CSSxRef("stroke-width")}} | |
| - Custom properties ({{cssxref("--*"))}} |
Contributor
Author
|
Hi @estelle , I’ve removed the vendor-prefixed properties and kept only the spec-defined allowable properties. Please let me know if this looks good now. Thanks! |
Member
I haven't tested them since they props only apply to svg, but the spec reads |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###Description
This PR corrects the “Allowable properties” section for the ::highlight pseudo-element.
It removes vendor-prefixed properties and updates the list to use the standard stroke-color, fill-color, and stroke-width properties.
###Motivation
The MDN page currently lists -webkit-text-* properties as allowable, which does not match the CSS specification.
This change aligns the documentation with the spec and prevents developers from relying on unsupported properties.
###Related issues and pull requests
Fixes #42863