Skip to content

Conversation

@nikelborm
Copy link
Contributor

Reformatted the representation of GDK_KEY_AudioForward and Qt:Key_AudioForward for consistency with other cells' style.

Reformatted the representation of GDK_KEY_AudioForward and Qt:Key_AudioForward for consistency with other cells' style.
@nikelborm nikelborm requested a review from a team as a code owner January 5, 2026 03:21
@nikelborm nikelborm requested review from wbamberg and removed request for a team January 5, 2026 03:21
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Jan 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

Preview URLs

Flaws (2)

URL: /en-US/docs/Web/API/UI_Events/Keyboard_event_key_values
Title: Key values for keyboard events
Flaw count: 2

  • macros:
    • Macro defaultapisidebar produces link /en-US/docs/Web/API/Element/select_event which is a redirect
    • Macro defaultapisidebar produces link /en-US/docs/Web/API/Window/abort_event which doesn't resolve

(comment last updated: 2026-01-06 23:42:14)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

I'm not sure what the inconsistency that this PR is addressing is, but this PR seems to be incorrect. The existing doc wants (I think) to include two keycodes in one cell in the "Linux" column, one for GDK and one for Qt. But this PR splits it into two cells, the first under "Linux" and the second under "Android", which is I think wrong. Then the cell that's currently under "Android" gets pushed out of the table:

Screenshot 2026-01-06 at 3 16 24 PM

Without knowing what the PR intended, though, it's hard to know what it should be doing instead of this.

@nikelborm
Copy link
Contributor Author

nikelborm commented Jan 6, 2026

Oh, yes, you're right! Sorry, I didn't mean to make it this way. Thanks for catching that! I was overconfident in the change, because it seemed very trivial, so I didn't validate it does what I intended, before sending it, because I made it in GitHub's UI. I meant to make 2 code tags that cover only the words individually instead of 1 code tag that spans across the whole cell. In all other cells there are 2 code tags instead of 1 spanning across the whole cell. Basically the fix of the same fashion as in #42624. Fixed the tag that wasn't split-apart in-between. I now fixed the PR. This is the consistent style I wanted to bring it to:

Screenshot From 2026-01-07 02-44-40 Screenshot From 2026-01-07 02-44-31
Main before PR Current state of the PR
Screenshot From 2026-01-07 02-48-18 Screenshot From 2026-01-07 02-47-46

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see now. That makes sense, thank you!

@wbamberg wbamberg merged commit 21b6057 into mdn:main Jan 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants