-
Notifications
You must be signed in to change notification settings - Fork 23.1k
Refactor chrome_settings_overrides page to use <dl> syntax
#42580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor chrome_settings_overrides page to use <dl> syntax
#42580
Conversation
|
Preview URLs Flaws (3)URL:
External URLs (1)URL:
(comment last updated: 2026-01-05 22:45:27) |
|
I'm not a reviewer for the webextensions docs, so this is just informational, but: an alternative which is adopted by the other MDN docs is to use a definition list for the properties, with MDN's These get anchors auto-applied in the platform so you can link to things like Advantages of doing this:
The disadvantage is that you don't have a consistent/structured way to capture the property type, you just have to put it in the description. If @rebloor wanted to do this, it should be done for all the manifest members of course, so as to be internally consistent. |
|
Thanks @wbamberg I'm already reviewing this with the team. |
I am in favor of following MDN's convention here. Ideally consistently across all articles that have such a table. We have to start somewhere, I'd be okay with this PR covering One potential challenge here is that properties can be nested. In this specific example even, the
That's fine by me. We don't need a whole column for just a type; many other WebExtension documentation have the type inline at the front (e.g. MDN: webRequest.onBeforeRequest). |
We have numerouse example fo nexted properties lists in the API\s, e.g. browserAction.onClicked
Arguably that's a much cleaner, obvious presentation of nested properties. |
|
@RobertCraigie would you like to go ahead and make the changes. You can find more information on the syntax in. MDN's
|
855544f to
fc5c7f8
Compare
chrome_settings_overrides fieldschrome_settings_overrides page to use <dl> syntax
rebloor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RobertCraigie thanks for these changes. I've left a couple of comments to flag that the search_provider is an object in its opening sentence and adjust the text before the properties list, give the reader now knows that it's an object.
files/en-us/mozilla/add-ons/webextensions/manifest.json/chrome_settings_overrides/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/manifest.json/chrome_settings_overrides/index.md
Outdated
Show resolved
Hide resolved
fc5c7f8 to
16a0139
Compare
rebloor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RobertCraigie


Description
Adds anchors for all the fields in the
chrome_settings_overridesweb extensions docs so they can be directly linked to.Motivation
I wanted to share a link to the
search_providersection but it is currently awkward to share a direct link to the right position as you can only use the "Copy link to highlight" version0, and even then it doesn't scroll as nicely as it does with an explicit anchor on the row imo.Additional details