Skip to content

Conversation

@RobertCraigie
Copy link
Contributor

@RobertCraigie RobertCraigie commented Dec 30, 2025

Description

Adds anchors for all the fields in the chrome_settings_overrides web extensions docs so they can be directly linked to.

Motivation

I wanted to share a link to the search_provider section but it is currently awkward to share a direct link to the right position as you can only use the "Copy link to highlight" version0, and even then it doesn't scroll as nicely as it does with an explicit anchor on the row imo.

Additional details

Screenshot 2026-01-02 at 8 49 51 pm

@github-actions github-actions bot added Content:WebExt WebExtensions docs size/s [PR only] 6-50 LoC changed labels Dec 30, 2025
@RobertCraigie RobertCraigie marked this pull request as ready for review December 30, 2025 23:48
@RobertCraigie RobertCraigie requested a review from a team as a code owner December 30, 2025 23:48
@RobertCraigie RobertCraigie requested review from rebloor and removed request for a team December 30, 2025 23:48
@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025

Preview URLs

Flaws (3)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/chrome_settings_overrides
Title: chrome_settings_overrides
Flaw count: 3

  • unknown:
    • No generic content config found
    • no blog root
    • no blog root
External URLs (1)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/chrome_settings_overrides
Title: chrome_settings_overrides

(comment last updated: 2026-01-05 22:45:27)

@wbamberg
Copy link
Collaborator

I'm not a reviewer for the webextensions docs, so this is just informational, but: an alternative which is adopted by the other MDN docs is to use a definition list for the properties, with MDN's <dl> syntax.

These get anchors auto-applied in the platform so you can link to things like RequestInit.mode or icons.sizes.

Advantages of doing this:

  • it makes the webextension docs more consistent with the rest of MDN
  • you can do it in just Markdown
  • the description gets the whole width of the page, rather than being squeezed into a single column

The disadvantage is that you don't have a consistent/structured way to capture the property type, you just have to put it in the description.

If @rebloor wanted to do this, it should be done for all the manifest members of course, so as to be internally consistent.

@rebloor
Copy link
Contributor

rebloor commented Jan 1, 2026

Thanks @wbamberg I'm already reviewing this with the team.

@Rob--W
Copy link
Member

Rob--W commented Jan 2, 2026

I'm not a reviewer for the webextensions docs, so this is just informational, but: an alternative which is adopted by the other MDN docs is to use a definition list for the properties, with MDN's <dl> syntax.

These get anchors auto-applied in the platform so you can link to things like RequestInit.mode or icons.sizes.

I am in favor of following MDN's convention here. Ideally consistently across all articles that have such a table. We have to start somewhere, I'd be okay with this PR covering chrome_settings_overrides only.

One potential challenge here is that properties can be nested. In this specific example even, the search_provider row encapsulates several other properties. I'm not sure if the result (of using definition lists) would be as readable, but I'm willing to consider it.

The disadvantage is that you don't have a consistent/structured way to capture the property type, you just have to put it in the description.

That's fine by me. We don't need a whole column for just a type; many other WebExtension documentation have the type inline at the front (e.g. MDN: webRequest.onBeforeRequest).

@rebloor
Copy link
Contributor

rebloor commented Jan 2, 2026

One potential challenge here is that properties can be nested. In this specific example even, the search_provider row encapsulates several other properties. I'm not sure if the result (of using definition lists) would be as readable, but I'm willing to consider it.

We have numerouse example fo nexted properties lists in the API\s, e.g. browserAction.onClicked

image

Arguably that's a much cleaner, obvious presentation of nested properties.

@rebloor
Copy link
Contributor

rebloor commented Jan 2, 2026

@RobertCraigie would you like to go ahead and make the changes. You can find more information on the syntax in. MDN's

syntax. If you have any issues, please let me know.

@RobertCraigie RobertCraigie force-pushed the chrome-settings-overrides/headers branch from 855544f to fc5c7f8 Compare January 2, 2026 20:49
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Jan 2, 2026
@RobertCraigie
Copy link
Contributor Author

Updated! It now looks like this:
Screenshot 2026-01-02 at 8 49 51 pm

Definitely much easier to read.

@RobertCraigie RobertCraigie changed the title Add anchors to chrome_settings_overrides fields Refactor chrome_settings_overrides page to use <dl> syntax Jan 2, 2026
Copy link
Contributor

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobertCraigie thanks for these changes. I've left a couple of comments to flag that the search_provider is an object in its opening sentence and adjust the text before the properties list, give the reader now knows that it's an object.

@RobertCraigie RobertCraigie force-pushed the chrome-settings-overrides/headers branch from fc5c7f8 to 16a0139 Compare January 4, 2026 21:50
@RobertCraigie RobertCraigie requested a review from rebloor January 4, 2026 21:51
Copy link
Contributor

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebloor rebloor merged commit 8ba4249 into mdn:main Jan 5, 2026
7 checks passed
@RobertCraigie RobertCraigie deleted the chrome-settings-overrides/headers branch January 5, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants