docs(learn): remove invalid type attribute from video example #42479
Conversation
kashish2710
requested review from
hamishwillee
and removed request for
a team
github-actions
bot
added
Content:Learn
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| Just below the `<h1>`, add a `<video>` element that embeds our header video into the page. We'd like it to do the following: | ||
|
|
||
| - Specify the [media type](/en-US/docs/Web/HTTP/Guides/MIME_types) of the video. | ||
| - If you provide multiple video sources, specify the media type using <source> elements. |
There was a problem hiding this comment.
[markdownlint] reported by reviewdog 🐶
error MD033/no-inline-html Inline HTML [Element: source]
|
I noticed the MD033/no-inline-html warning from reviewdog regarding the use of |
The reason for this is that you referred to "<video>" unescaped in Markdown, and because you can embed HTML in Markdown, that gets interpreted as HTML. Options for fixing it, from worse to better:
However, I think in this case it is better to omit the bullet entirely, as you have done, because there's no expectation that the reader will use multiple files (only one is provided). @tristantheb , thank you for filing this issue. Does the fix look good to you? |
| Just below the `<h1>`, add a `<video>` element that embeds our header video into the page. We'd like it to do the following: | ||
|
|
||
| - Specify the [media type](/en-US/docs/Web/HTTP/Guides/MIME_types) of the video. | ||
| - If you provide multiple video sources, specify the media type using <source> elements. |
There was a problem hiding this comment.
-- If you provide multiple video sources, specify the media type using <source> elements.
+- If you provide multiple video sources, specify the media type using {{HTMLElement("source")}} elements.When you want to add an html element, it's with this macro or with backticks like this
-- If you provide multiple video sources, specify the media type using <source> elements.
+- If you provide multiple video sources, specify the media type using `<source>` elements.;)
Looks good for me, when it's sent, I'll let the person who reported the issue on Discord know that it's being fixed :D Thanks 🙏🏻 |
wbamberg
left a comment
wbamberg
left a comment
There was a problem hiding this comment.
👍 thank you @kashish2710 and @tristantheb !
…skeys-guide * origin/add-passkeys-guide: Clarify fetch() error handling behavior for Response (mdn#42497) Add code example to Closure glossary entry (mdn#42477) 42252 add new relative units ff release (mdn#42470) Remove duplicated word (mdn#42496) 42252 add new relative units (mdn#42469) TrustedTypes: Range.createContextualFragment() (mdn#42493) Fix CSS, HTML, and HTTP landing pages to match sidebar content and order (mdn#42460) TT: CSP trusted types/require-trusted... fixes (mdn#42461) Improve console output formatting in Recursion glossary (mdn#42478) Add Sec-CH-Width + consistency fixes (mdn#42453) webextensions/manifest.json/options_page: typo (mdn#42394) webextensions/api/tabs/onupdated: Fix section link (mdn#42393) fix: add missing closing parenthesis (mdn#42482) docs: mark srcData as required in bufferSubData (mdn#42483) docs(learn): remove invalid type attribute from video example (mdn#42479) Drop 'read-only' from role (mdn#42474) Fix: Update bufferSubData parameters to match WebGL 1 spec mdn#42315 (mdn#42411) chore: Replace links with `cssxref` macro in the learn area (mdn#42446)
3 participants
Removes the invalid
typeattribute from the <video> element in theCreepy-crawly splash page solution and updates the instructions to avoid
misleading learners. The
typeattribute should only be used with<source> elements, not directly on <video>.