Skip to content

Conversation

@bharath-mp-2005
Copy link
Contributor

Updates the Google Fonts instructions in the Web fonts learning article to reflect the current Google Fonts interface and embed flow.

Fixes #42385

Updates the Google Fonts instructions in the Web fonts learning article to reflect the current Google Fonts interface and embed flow.

Fixes mdn#42385
@bharath-mp-2005 bharath-mp-2005 requested a review from a team as a code owner December 15, 2025 09:54
@bharath-mp-2005 bharath-mp-2005 requested review from hamishwillee and removed request for a team December 15, 2025 09:54
@github-actions github-actions bot added Content:Learn Learning area docs size/s [PR only] 6-50 LoC changed labels Dec 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Preview URLs

Flaws (1)

URL: /en-US/docs/Learn_web_development/Core/Text_styling/Web_fonts
Title: Web fonts
Flaw count: 1

  • macros:
    • Macro ? produces link /en-US/curriculum/ which doesn't resolve
External URLs (6)

URL: /en-US/docs/Learn_web_development/Core/Text_styling/Web_fonts
Title: Web fonts

(comment last updated: 2025-12-16 14:33:37)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @bharath-mp-2005, and thank you for submitting a fix for this issue!

I've provided some suggestions for further improvement for you to consider. One of the main points is that I've suggested rewriting the instructions to mention selecting more than one font. I thought this would be a good idea anyway, and that it would also be more in keeping with the previous example, which asks the reader to use two fonts.

Let me know what you think. Thanks again!

@chrisdavidmills chrisdavidmills removed the request for review from hamishwillee December 15, 2025 15:14
bharath-mp-2005 and others added 7 commits December 15, 2025 23:31
…index.md

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
…index.md

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
…index.md

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
…index.md

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
…index.md

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
…index.md

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@bharath-mp-2005
Copy link
Contributor Author

Thanks very much for the suggestions, Chris - they make a lot of sense 👍
I've applied them all and updated the instructions to better reflect selecting multiple fonts.
Please let me know if you'd like any further tweaks.

@bharath-mp-2005
Copy link
Contributor Author

Thanks again, Chris! I've applied all the suggested changes.
Happy to squash commits if you'd prefer a cleaner history — just let me know.

Updated text for clarity and consistency in the web fonts guide.
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @bharath-mp-2005!

I have taken this opportunity to fix a few minor grammar issues while I am here. I think this is ready to merge now.

@chrisdavidmills chrisdavidmills merged commit 80c1b90 into mdn:main Dec 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Learn Learning area docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Fonts instructions out of date?

2 participants