-
Notifications
You must be signed in to change notification settings - Fork 23.1k
Update Google Fonts instructions to match current UI #42398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates the Google Fonts instructions in the Web fonts learning article to reflect the current Google Fonts interface and embed flow. Fixes mdn#42385
|
Preview URLs Flaws (1)URL:
External URLs (6)URL:
(comment last updated: 2025-12-16 14:33:37) |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @bharath-mp-2005, and thank you for submitting a fix for this issue!
I've provided some suggestions for further improvement for you to consider. One of the main points is that I've suggested rewriting the instructions to mention selecting more than one font. I thought this would be a good idea anyway, and that it would also be more in keeping with the previous example, which asks the reader to use two fonts.
Let me know what you think. Thanks again!
files/en-us/learn_web_development/core/text_styling/web_fonts/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/text_styling/web_fonts/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/text_styling/web_fonts/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/text_styling/web_fonts/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/text_styling/web_fonts/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/text_styling/web_fonts/index.md
Outdated
Show resolved
Hide resolved
…index.md Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
…index.md Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
…index.md Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
…index.md Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
…index.md Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
…index.md Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
|
Thanks very much for the suggestions, Chris - they make a lot of sense 👍 |
|
Thanks again, Chris! I've applied all the suggested changes. |
Updated text for clarity and consistency in the web fonts guide.
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @bharath-mp-2005!
I have taken this opportunity to fix a few minor grammar issues while I am here. I think this is ready to merge now.
Updates the Google Fonts instructions in the Web fonts learning article to reflect the current Google Fonts interface and embed flow.
Fixes #42385