-
Notifications
You must be signed in to change notification settings - Fork 23.1k
chore: Cleanup older Firefox release notes #42372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
88c41a0 to
e2f00e9
Compare
|
@pepelsbey I've removed the comments as discussed (they're not needed because the script automatically handles empty sections). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you reordered MathML and SVG, but it was on purpose to have them right after HTML, since they're also markup languages.
Also, there are still many "remove X if empty" comments left that we don't need, as the release script handles removals automatically.
So, the idea is:
- All section headings are commented and will be removed automatically if empty, apart from HTML, CSS, and JavaScript.
- Only HTML, CSS, and JavaScript sections have "no notable changes" comments that will be uncommented.
We don't need any other comments or changes to the template, apart from adding the DevTools section.
|
This pull request has merge conflicts that must be resolved before it can be merged. |
03434e4 to
268006e
Compare
Oops! I removed them from the template file but missed removing them from 147 and 148 relnote files. All gone now 👍
Yes, that makes logical sense and I gathered that would have been the reason. In fact, I applied the reordering because I assumed that was the sequence we've used historically.
(I just resolved some merge conflicts in 147 and I haven't updated the order in it yet, pending what we decide to do with the sequence.) |
There was a moment when I started doing this for logical grouping. That's why it doesn't go all the way back and there are only 7 in that order. I would suggest keeping changes to a minimum, given the plans for this section, and focus on improving the template for the future releases. |
Makes sense. I'll push an update shortly to undo the template changes |
fab83a9 to
a08dcf0
Compare
pepelsbey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you :)
Description
This PR updates the Firefox release note template (follow-up to #42319 (comment)) and a few previous release note files.
- Added instruction to delete "Removals" if the section is empty.- Added section-specific deletion instruction, "Delete entire [section] section if no updates", because we remove the parent section for HTTP, SVG, MathML, Security, etc if they're empty. (It'll be good to have this info in the template rather than having to check our convention every time.)- Added "No notable changes." to "Changes for add-on developers" as well since we always keep this section. (We use this label for the core sections for HTML, CSS, and JavaScript that we don't delete.)2. In the latest released (146), beta (147), and nightly (148) files, made updates to reflect changes in the template.3. In the remaining files:
- Updated casing in "## Changes for Web developers" to "## Changes for web developers"
- Updated the placement of the "Developer Tools" section to the top (when present)
- Removed "Developer Tools" section where it was empty (123)
Motivation
Ordering the technologies/areas in the logical progression, starting with Dev Tools, then core technologies, followed by others
/cc @pepelsbey