Updates to modulepreload and preload to incorporate WHATWG changes for "style" and "json"
#42333
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KurtCattiSchmidt
requested review from
chrisdavidmills
and removed request for
a team
github-actions
bot
added
Content:HTML
6 tasks
Contributor
Contributor
chrisdavidmills
left a comment
chrisdavidmills
left a comment
There was a problem hiding this comment.
@KurtCattiSchmidt Hi there, and thanks for the update. The changes seem reasonable as per the suggested spec change; I've given you a couple of minor suggestions to consider.
One thing though — it would make sense to hold off on this MDN change at least until the spec change is merged, so that MDN is consistent with the spec.
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates docs for
preloadandmodulepreloadper WHATWG changes in whatwg/html#11981Motivation
This change aligns behavior with the current specs.
Additional details
Do not land until the WHATWG PR lands.
Related issues and pull requests