-
Notifications
You must be signed in to change notification settings - Fork 23.1k
feat(jsondata): add translations for CSS formal definitions #42241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
"ignorePaths": [
".vscode/cspell.json",
".vscode/extensions.json",
".markdownlint-cli2.jsonc",
+ "files/jsondata/L10n-*.json"
],(ignorePaths supports wildcards, see: https://cspell.org/docs/getting-started#2-add-words-to-the-project-dictionary)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsmth Can you (spell-)check again?
bsmth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 👍🏻

Description
Adds translations for the mdn-data-free version of rari. Existing translations on the formal definition values cannot be carried over, so there is a new translations file with only en-US values pre-filled and the rest auto-translated for a baseline.
Motivation
Remove mdn-data dependency from the publishing pipeline.
Additional details
This is compatible with the old and the new approach to formal definitions. Before merging the rari-part of this, nothing will change on the output.
Related issues and pull requests
See related rari PR: mdn/rari#390