Skip to content

Conversation

@argl
Copy link
Contributor

@argl argl commented Dec 5, 2025

Description

Adds translations for the mdn-data-free version of rari. Existing translations on the formal definition values cannot be carried over, so there is a new translations file with only en-US values pre-filled and the rest auto-translated for a baseline.

Motivation

Remove mdn-data dependency from the publishing pipeline.

Additional details

This is compatible with the old and the new approach to formal definitions. Before merging the rari-part of this, nothing will change on the output.

Related issues and pull requests

See related rari PR: mdn/rari#390

@github-actions github-actions bot added the size/xl [PR only] >1000 LoC changed label Dec 5, 2025
@github-actions github-actions bot added the system [PR only] Infrastructure and configuration for the project label Dec 5, 2025
@argl argl marked this pull request as ready for review December 8, 2025 13:50
@argl argl requested review from a team as code owners December 8, 2025 13:50
@argl argl requested review from bsmth and caugner and removed request for a team December 8, 2025 13:50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spellchecker doesn't like this:

Image

We may want to temporarily ignore in .vscode/cspell.json:

  "ignorePaths": [
    ".vscode/cspell.json",
    ".vscode/extensions.json",
    ".markdownlint-cli2.jsonc",
+   "files/jsondata/L10n-CSSFormalDefinitions.json"
  ],

Copy link
Contributor

@caugner caugner Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

  "ignorePaths": [
    ".vscode/cspell.json",
    ".vscode/extensions.json",
    ".markdownlint-cli2.jsonc",
+   "files/jsondata/L10n-*.json"
  ],

(ignorePaths supports wildcards, see: https://cspell.org/docs/getting-started#2-add-words-to-the-project-dictionary)

Copy link
Contributor

@caugner caugner Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsmth Can you (spell-)check again?

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍🏻

@caugner caugner merged commit d21d8f3 into main Dec 11, 2025
12 checks passed
@caugner caugner deleted the translations-for-css-formal-definitions branch December 11, 2025 17:05
@caugner caugner changed the title Translations for css formal definitions feat(jsondata): add translations for CSS formal definitions Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl [PR only] >1000 LoC changed system [PR only] Infrastructure and configuration for the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants