TrustedTypes: Document.execCommand() with command insertHTML #42238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
8 tasks
Contributor
|
Preview URLs |
34 tasks
wbamberg
approved these changes
Jan 1, 2026
Collaborator
wbamberg
left a comment
wbamberg
left a comment
There was a problem hiding this comment.
👍 thanks, looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document.execCommand()with commandinsertHTMLis an injection sink.Given that this is just a small part of what the method does, and that the method is deprecated, I have added the disclaimer to the point where
insertHTMLis documented. The disclaimer does not link to a security considerations section, but instead points to the TT API overview. I think this is the right level.Project tracking in #41507