-
Notifications
You must be signed in to change notification settings - Fork 22.9k
HTTP response headers - replace forbidden request #41946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| </tr> | ||
| <tr> | ||
| <th scope="row">{{Glossary("Forbidden response header name")}}</th> | ||
| <th scope="row">{{Glossary("Forbidden response header name","Forbidden response header")}}</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only one, so it might be good to think about changing this to:
<th scope="row">Header type</th>
<td>{{Glossary("Response header")}}, {{Glossary("Forbidden response header name", "Forbidden response header")}}</td>And remove all of the No <tr> entries seeing as they don't add much additional info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsmth I did think about this. I accept it would be "better" to remove the row on the basis that given there are so few of these cases people will get use to see "no" and ignore it.
My reason for not doing this was a bit "weak" - to me it looks ugly to have a single header table. Below is what this looks like 3 ways: HTML table as it is now, HTML table with the row removed, and using a markdown table.
Do you have a preference? If not, I propose to simple remove the rows leaving us with the middle option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks ugly to have a single header table.
That's a good point, there's not much left in the table.
Do you have a preference? If not, I propose to simple remove the rows leaving us with the middle option.
I think that's cleaner for now. I guess eventually this is front-matter material, but removing the redundant ones is a good cleanup, IMO 👍🏻
bsmth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the cleanup. One suggestion to think about for UX purposes / removing redundant info, but already a good fix, tnx 👍🏻
As discussed in #41938 (comment) , response headers should not have the section on "forbidden request headers". I have modified this so that response headers listed in #41938 (comment) now have "Forbidden response header" instead.
I also updated the request and response headers to include the forbidden response information.