Skip to content

Update exception information for Navigation.navigate() #41915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chrisdavidmills merged 5 commits into from
Dec 1, 2025
Merged

Update exception information for Navigation.navigate() #41915

chrisdavidmills merged 5 commits into from
Dec 1, 2025

Conversation

@chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Nov 12, 2025 •
edited
Loading

Description

The Navigation.navigate() method now disallows javascript: URLs for security purposes. See whatwg/html#11533.

This PR:

  • Corrects the related info on the ref page (it was already there but inaccurate).
  • Adds another missing exception to the page and makes some additions and minor cleanup.
  • Adds a rel note mentioning it to the Fx144 rel notes (which is when Firefox implemented this; see https://bugzilla.mozilla.org/show_bug.cgi?id=1981104)

Motivation

Additional details

Related issues and pull requests

Fixes #40806

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner November 12, 2025 13:52
@chrisdavidmills chrisdavidmills requested review from sideshowbarker and removed request for a team November 12, 2025 13:52
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Nov 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025 •
edited
Loading

Preview URLs

External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/144
Title: Firefox 144 release notes for developers

(comment last updated: 2025-12-01 16:19:03)

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner November 12, 2025 14:01
@chrisdavidmills chrisdavidmills requested review from pransh15 and removed request for a team November 12, 2025 14:01
@github-actions github-actions bot added the Content:Firefox Content in the Mozilla/Firefox subtree label Nov 12, 2025
@chrisdavidmills chrisdavidmills mentioned this pull request Nov 12, 2025
Closed
9 tasks
@sideshowbarker sideshowbarker removed their request for review November 22, 2025 11:02
dipikabh
dipikabh approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @chrisdavidmills!
It's looking good, just a few small suggestions. Approving :)

@chrisdavidmills chrisdavidmills merged commit b5a7c20 into mdn:main Dec 1, 2025
8 checks passed
@chrisdavidmills chrisdavidmills deleted the javascript-urls-disallowed-in-navigate-method branch December 1, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dipikabh dipikabh dipikabh approved these changes

@pransh15 pransh15 Awaiting requested review from pransh15 pransh15 is a code owner automatically assigned from mdn/content-team

Assignees

No one assigned

Labels

Content:Firefox Content in the Mozilla/Firefox subtree Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

navigation.navigate() with a javascript: protocol is now unsupported

2 participants

@chrisdavidmills @dipikabh