-
Notifications
You must be signed in to change notification settings - Fork 22.9k
Docs: Improve and clarify Promise terminology section #41565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Improve and clarify Promise terminology section #41565
Conversation
Preview URLs (comment last updated: 2025-10-17 19:40:37) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @amritamishra01; this is going in the right direction. I've got a few suggestions for you.
files/en-us/learn_web_development/extensions/async_js/promises/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/extensions/async_js/promises/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/extensions/async_js/promises/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/extensions/async_js/promises/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/extensions/async_js/promises/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/extensions/async_js/promises/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another comment
files/en-us/learn_web_development/extensions/async_js/promises/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/extensions/async_js/promises/index.md
Outdated
Show resolved
Hide resolved
Hi! @chrisdavidmills 👋 |
Sorry, but we don't have those labels on our system; we don't actively participate in hacktoberfest. Is there no other way to include this in your contributions? Also, did you make the changes I requested? Normally, you would accept the suggestions using the "Commit suggestion" buttons, and/or write a comment to respond to them. I think you have so I'll just read the document through again and check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks complete now. Thank you for your contribution, @amritamishra01!
Description
This PR improves the “Promise terminology” section for better readability and clarity. The section has been restructured, and definitions have been simplified to be more accessible for learners.
Motivation
This change addresses a suggestion from a maintainer in issue #41538 to update the terminology section. The main goal is to resolve an inconsistency in the article by adding a definition for the term “completed” and explaining its relationship to “settled.”
Related issues
Fixes #41538