Skip to content

Conversation

amritamishra01
Copy link
Contributor

Description

This PR improves the “Promise terminology” section for better readability and clarity. The section has been restructured, and definitions have been simplified to be more accessible for learners.

Motivation

This change addresses a suggestion from a maintainer in issue #41538 to update the terminology section. The main goal is to resolve an inconsistency in the article by adding a definition for the term “completed” and explaining its relationship to “settled.”

Related issues

Fixes #41538

@amritamishra01 amritamishra01 requested a review from a team as a code owner October 16, 2025 17:57
@amritamishra01 amritamishra01 requested review from chrisdavidmills and removed request for a team October 16, 2025 17:57
@github-actions github-actions bot added Content:Learn Learning area docs size/s [PR only] 6-50 LoC changed labels Oct 16, 2025
Copy link
Contributor

github-actions bot commented Oct 16, 2025

Preview URLs

(comment last updated: 2025-10-17 19:40:37)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @amritamishra01; this is going in the right direction. I've got a few suggestions for you.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another comment

@amritamishra01
Copy link
Contributor Author

Hi! @chrisdavidmills 👋
I contributed this PR as part of Hacktoberfest 2025.
Could you please add the hacktoberfest-accepted label or the hacktoberfest topic to the repo so it can count toward my participation?
Thank you for maintaining this project

@chrisdavidmills
Copy link
Contributor

Hi! @chrisdavidmills 👋 I contributed this PR as part of Hacktoberfest 2025. Could you please add the hacktoberfest-accepted label or the hacktoberfest topic to the repo so it can count toward my participation? Thank you for maintaining this project

Sorry, but we don't have those labels on our system; we don't actively participate in hacktoberfest. Is there no other way to include this in your contributions?

Also, did you make the changes I requested? Normally, you would accept the suggestions using the "Commit suggestion" buttons, and/or write a comment to respond to them. I think you have so I'll just read the document through again and check.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks complete now. Thank you for your contribution, @amritamishra01!

@chrisdavidmills chrisdavidmills merged commit 7dea5a0 into mdn:main Oct 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Learn Learning area docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An unclear sentence about promises

2 participants