-
Notifications
You must be signed in to change notification settings - Fork 22.8k
FF142 Relnote: URL Pattern API #40632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
||
## Interfaces | ||
|
||
The URL Pattern API only has a single related interface: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI not useful or in template.
@@ -55,6 +55,26 @@ new URLPattern(input, baseURL, options) | |||
- The given `input` is relative, but no `baseURL` is provided to form a complete absolute URL. | |||
- A `baseURL` is provided, and input is an absolute pattern or a structured object. | |||
|
|||
## Description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rename and move of the "Usage notes" section - Description is the preferred name for this in template
@@ -381,7 +375,7 @@ console.log(pattern.test("https://example.com/foo/bar")); // true | |||
|
|||
console.log(pattern.test({ hostname: "cdn.example.com" })); // true | |||
|
|||
console.log(pattern.test("custom-protocol://example.com/other/path?q=1")); // false | |||
console.log(pattern.test("custom-protocol://example.com/other/path?q=1")); // true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only actual error.
Preview URLs
External URLs (1)URL:
|
As I mentioned in #40474 (comment), I believe there are quite a few outdated/incorrect information pieces because the current docs were written when Chrome first implemented it and there were a lot of changes later. We should make sure that the current docs reflect both the spec and implementations by closing those issues as either not a problem anymore or work to resolve them. |
Thanks @Josh-Cena - missed that. Will do.
area: URL/URLPattern
|
FF142 adds support for the URL Pattern API in https://bugzilla.mozilla.org/show_bug.cgi?id=1731418
This adds a release note and some minor corrections to current Web API template style.
Related work can be tracked in #40474