Skip to content

Lint: use named color if possible (6) #40624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Lint: use named color if possible (6) #40624

wants to merge 2 commits into from
+151 −151

Conversation

Josh-Cena
Copy link
Member

After #40228, we are a lot more explicit on some CSS stylistic decisions. In particular, we now have systematic rules surrounding the preferred color notations. As a starter, I'm porting all colors that have named equivalents to named colors, per our recommendation of using "common named colors". Afterwards, I'm going to convert the remaining colors to the preferred notation, such as preferring rgb() and preferring number parameters.

@Josh-Cena Josh-Cena requested a review from a team as a code owner August 4, 2025 16:40
@Josh-Cena Josh-Cena requested review from estelle and removed request for a team August 4, 2025 16:40
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Aug 4, 2025
@Josh-Cena Josh-Cena requested review from dipikabh, bsmth and a team and removed request for estelle and a team August 4, 2025 16:41
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Aug 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025 •
edited
Loading

Preview URLs (72 pages)
Flaws (42)

Note! 51 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/marker
Title: marker
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier

URL: /en-US/docs/Web/CSS/marker-end
Title: marker-end
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/url which is a redirect

URL: /en-US/docs/Web/CSS/marker-mid
Title: marker-mid
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/url which is a redirect

URL: /en-US/docs/Web/CSS/marker-start
Title: marker-start
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/url which is a redirect

URL: /en-US/docs/Web/CSS/mask-image
Title: mask-image
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/url which is a redirect

URL: /en-US/docs/Web/CSS/max-block-size
Title: max-block-size
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/max-height
Title: max-height
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/max-inline-size
Title: max-inline-size
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/max-width
Title: max-width
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/min-block-size
Title: min-block-size
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/min-height
Title: min-height
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/min-inline-size
Title: min-inline-size
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/min-width
Title: min-width
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/mix-blend-mode
Title: mix-blend-mode
Flaw count: 1

  • broken_links:
    • /en-US/docs/Web/CSS/CSS_positioned_layout/Understanding_z-index/Stacking_context is a redirect

URL: /en-US/docs/Web/CSS/position
Title: position
Flaw count: 1

  • broken_links:
    • /en-US/docs/Web/CSS/CSS_positioned_layout/Understanding_z-index/Stacking_context is a redirect

URL: /en-US/docs/Web/CSS/shape-outside
Title: shape-outside
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/shape-box which is a redirect

URL: /en-US/docs/Web/CSS/stroke
Title: stroke
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier

URL: /en-US/docs/Web/CSS/transform-style
Title: transform-style
Flaw count: 1

  • broken_links:
    • /en-US/docs/Web/CSS/CSS_positioned_layout/Understanding_z-index/Stacking_context is a redirect

URL: /en-US/docs/Web/CSS/url_function
Title: url()
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token

URL: /en-US/docs/Web/CSS/var
Title: var()
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/custom-property-name
    • Can't resolve /en-US/docs/Web/CSS/declaration-value

URL: /en-US/docs/Web/CSS/width
Title: width
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

(comment last updated: 2025-08-05 13:54:10)

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Aug 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh Awaiting requested review from dipikabh

@bsmth bsmth Awaiting requested review from bsmth

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Josh-Cena