Remove inline style/script (API H–S) #39783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsmth
reviewed
Jun 4, 2025
|
Sorry I ran out of steam on these inline script/style ones. I'll cycle back to it shortly |
|
np. Take your time! |
bsmth
reviewed
Jun 11, 2025
bsmth
reviewed
Jun 11, 2025
| ``` | ||
|
|
||
| It's possible to send a notification as follows — here we present a fairly verbose and complete set of code you could use if you wanted to first check whether notifications are supported, then check if permission has been granted for the current origin to send notifications, then request permission if required, before then sending a notification. | ||
|
|
||
| ```js | ||
| document.querySelector("button").addEventListener("click", notifyMe); |
There was a problem hiding this comment.
Maybe for later, but this is a good page to add {{embedlivesample}} to.
bsmth
reviewed
Jun 11, 2025
bsmth
reviewed
Jun 11, 2025
bsmth
reviewed
Jun 11, 2025
|
I think that's everything, Josh, thanks for the improvements. As usual, checked diffs, ran a few examples to double-check, and checked live samples when they existed. A few comments for you to 🙏🏻 |
Co-authored-by: Brian Smith <brian@smith.berlin>
hamishwillee
pushed a commit
to yoavweiss/content
that referenced
this pull request
Jun 24, 2025
* Remove inline style/script (API H–S) * Apply suggestions from code review Co-authored-by: Brian Smith <brian@smith.berlin> --------- Co-authored-by: Brian Smith <brian@smith.berlin>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #39757