-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment with adding/updating Scrimba links #38488
base: main
Are you sure you want to change the base?
Experiment with adding/updating Scrimba links #38488
Conversation
Preview URLs (14 pages)
Flaws (25)Note! 7 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLs (22)URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
(comment last updated: 2025-03-11 09:45:29) |
@chrisdavidmills I'm not going to properly review this until it gets out of draft. The links seem to be a reasonable integration in the right places. They are definitely not overwhelming. This is the first time we've had preferential addition of links based on some kind of commercial affiliation rather than technical merit. That makes me uncomfortable, in part because what do we do when someone else comes along and PRs in their link in the same places but doesn't want to pay - according to MDN rules we then we have this whole argument about maintenance lists etc. Anyway, assuming their content is good, this is reasonable. Alternative is something like a clearly differentiated section for affiliate links. |
This pull request has merge conflicts that must be resolved before it can be merged. |
Cool, that's good to hear. The priority for these links is that they are useful, provide an alternative way of consuming some of the information we provide on learn, and are not spammy or annoying.
We deliberately published new guidelines to try to tackle this issue — https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Learning_content#external_links_and_embeds I'd be interested in your thoughts on whether these adequately address the problem, or if we need to make updates. I suspect some of my changes here have not followed the ""See also" link order" section guidance, which is my fault.
|
Thanks for the comments.
EDIT PS - I do like the updates to the guildelines above - they make it pretty clear that we're aware of the sensitivities. |
Description
This PR updates several Learn web development pages to add and/or modify the position of Scrimba learning partner affiliate links. The aim here is to make them more effective, more useful for our readers, and not feel too overwhelming or spammy.
Motivation
Additional details
Related issues and pull requests